SqlDataReader for ComboBox

Question

0.00/5 (No votes)

See more:

Hello friends,
I have got this code below which should select item from SQL DB column ubytov. But it doesn't select any value. Why?

C#

try
           {
               SqlCommand novyprikaz = new SqlCommand("SELECT * FROM klient WHERE akce=" + vyberradek, spojeni);
               spojeni.Open();
               SqlDataReader precti = novyprikaz.ExecuteReader();

               if (precti.Read())
               { comboBox2.SelectedItem = precti.GetString(precti.GetOrdinal("ubytov"));
               }

           }
           catch (Exception ex)
           {
               MessageBox.Show("Chybové hlášení2: " + ex.Message.ToString());
           }

           spojeni.Close();
       }

And this is how I fill it on form_load

C#

private void klient_Load(object sender, EventArgs e)
       {
           spojeni.Open();
           var cb1 = new SqlCommand("SELECT odjezd FROM stanice WHERE akce="
                            + vyberradek+ " ORDER BY odjezd ASC", spojeni);
           var cb2 = new SqlCommand("SELECT text FROM ubytov WHERE akce="
                           + vyberradek + " ORDER BY text ASC", spojeni);
           try
           {
               SqlDataReader dr = cb1.ExecuteReader();
               while (dr.Read())
               {
                   comboBox1.Items.Add(dr["odjezd"]);

               }
               dr.Close();
               dr.Dispose();
               SqlDataReader dr2 = cb2.ExecuteReader();
               while (dr2.Read())
               {
                   comboBox2.Items.Add(dr2["text"]);

               }
               dr2.Close();
               dr2.Dispose();

               spojeni.Close();
           }

Anyone know what should I do with it ?

Posted 15-Jul-13 20:59pm

mareksip

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thanks7872 · Accepted Answer · 2013-07-15T21:10:00

Advised to use parameterized query always. Showing example how to fill combo box(I assume klient is table name).

C#

SqlCommand novyprikaz = new SqlCommand("SELECT * FROM klient WHERE akce=@xyz", spojeni);
spojeni.Open();
cmd.Parameters.AddWithValue("xyz",your actual value);//like textbox text
SqlDataAdapter da = new SqlDataAdapter(novyprikaz);
DataSet ds = new DataSet();
da.Fill(ds);
comboBox2.DataSource=ds;
comboBox2.DataBind();

Regards.. :laugh: