data retrieval from database using three tier Architecture

Question

0.00/5 (No votes)

See more:

PROPERTY LAYER

C#

public string MemberID
     {
         get { return _MemberID; }
         set { _MemberID = value; }
     }

DATAACCESS LAYER

SQL

public DataSet Max_Member_Id(Configure_MasterPL obj, Member_MasterPL objmem)
   {

       SqlCon.Open();
       sqlCmd = new SqlCommand("SELECT ISNULL(MAX(CONVERT(NUMERIC,MEMNO)),0)+1 FROM MEMBER_MASTER WITH (NOLOCK), SqlCon);
       objmem.MemberID= Convert.ToString(sqlCmd.ExecuteScalar());
       sqlCmd.Dispose();
       SqlCon.Close();

       return ds;

   }

BUSSINESSACCESS LAYER

SQL

public DataSet MaxMemcode(Configure_MasterPL obj, Member_MasterPL memobj)
{
    return objMember.Max_Member_Id(obj,memobj);
}

PRESENTATION LAYER

C#

private void max()
{
 string MEM_CODE = "";
        DataSet ds1 = new DataSet();
        objMemberMasterPL.MemberID = "0";        
        ds1 = objMemberMasterBAL.MaxMemcode(objMemberMasterPL);     
       
        dt = ds1.Tables[0];
        ArrayList ar = new ArrayList();
        if (dt.Rows.Count > 0)
        {
            for (int i = 0; i < dt.Rows.Count; i++)
            {
                MEM_CODE = dt.Rows[i]["MEMNO"].ToString();
               
                ar.Add(MEM_CODE);
            }
            ar.Sort();
          
           
    }
        ds1.Clear();
}

it can'nt read data in presentation layer,, plz hlep me,,plz,,,

Posted 24-Sep-13 1:22am

Member 9959371

Updated 24-Sep-13 2:50am

v3

Add a Solution

Comments

[no name] 24-Sep-13 7:32am

The error you received when you debugged your code would have told you exactly what the problem was. "ds" is not defined in your Max_hodMember_Id method.

Member 9959371 24-Sep-13 8:55am

so,, not ds,,it is ds1,,plz hlep me

[no name] 24-Sep-13 9:10am

No it is clearly "ds" that you are trying to return and that does not exist. You need to learn how to debug your code.

Member 9959371 24-Sep-13 9:17am

the data can't read in presentationlayer ,, to throw error 'array not bound'

[no name] 24-Sep-13 9:48am

That is because you are returning something called "ds" from your Max_Member_Id method that is not defined! Can you not read?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas ktg · Accepted Answer · 2013-09-24T03:41:00

First of all you have not used to declare the proper data type for your methods and thus make you to get confused. Here is the rearrangement of your code which would make sense.
In Data Access Layer

//Change the return type as string since you are using ExecuteScalar.
//You can change the method type based on the return type.

C#

public string Max_Member_Id(Configure_MasterPL obj, Member_MasterPL objmem)
{
       SqlCon.Open();
       sqlCmd = new SqlCommand("SELECT ISNULL(MAX(CONVERT(NUMERIC,MEMNO)),0)+1 FROM MEMBER_MASTER WITH (NOLOCK), SqlCon);
       objmem.MemberID= Convert.ToString(sqlCmd.ExecuteScalar());
       sqlCmd.Dispose();
       SqlCon.Close();

       return objmem.MemberID;
}

In Bussiness Layer
//Change the type string

SQL

public string MaxMemcode(Configure_MasterPL obj, Member_MasterPL memobj)
{
    return objMember.Max_Member_Id(obj,memobj);
}

In Presentation Layer
//ExecuteScalar method to retrieve a single value (for example, an aggregate value) from a database. Thus you can not assign that for the DataSet.

C#

private void max()
{
        string MEM_CODE = "";
        //DataSet ds1 = new DataSet();
        objMemberMasterPL.MemberID = "0";        
         
        //Get the max code
        MEM_CODE= objMemberMasterBAL.MaxMemcode(objMemberMasterPL);  
   
        //ds1 = objMemberMasterBAL.MaxMemcode(objMemberMasterPL);     
       
        //All these are not required according to your methods provided here.

        /*dt = ds1.Tables[0];
        ArrayList ar = new ArrayList();
        if (dt.Rows.Count > 0)
        {
            for (int i = 0; i < dt.Rows.Count; i++)
            {
                MEM_CODE = dt.Rows[i]["MEMNO"].ToString();
               
                ar.Add(MEM_CODE);
            }
            ar.Sort();
          
           
        }
        ds1.Clear();*/
}

Hope this would help in some way or other.