how to call system command with variable parameters

Question

0.00/5 (No votes)

See more:

Hello,
I'm looking for a way to call system commands with variable parameters
within a Window environment.
Sort of like system() but i need to be
able to pass variable parameters.
I tried this:
system("command -%s -%s", parameter1, parameter2);

and this

C#

char buffer[200];
    string p="192.168.1.100";
    sprintf(buffer,"ping %s",p);

    system(buffer);
    system("pause");

However, i still get error.
Can someone direct me, what i am doing wrong?

Best Regards,
Victor

Posted 28-Oct-13 4:38am

Vic.k

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Aescleal · Answer 1 · 2013-10-28T06:27:00

The problem with your code is that you're passing a std::string to sprintf, which wouldn't know what a string was if one came up and twatted it with a cricket bat. I'd suggest using a stringstream to format the string rather than sprintf - there's no chance of a buffer overflow.

Once you've got the command to execute the next fun-part is getting the results back...

Jochen Arndt · Answer 2 · 2013-10-28T05:38:00

Your example code is OK and will execute the ping command. But if your parameters contain spaces, quotes or specific reserved characters, you must enclose these parameters by quotes. To be on the save side, you should also enclose the complete command by quotes. Your ping example would then look like this:

sprintf(buffer,"\"ping \"%s\"\"",p);

To make it more complicated, there is another special case when a parameter itself is enclosed by double quote characters. Then it must be enclosed by another pair of quotes.

The system() functions runs the command as 'cmd /c command'. You can open a command shell and execute 'help cmd' to get some information on quoting.

Vic.k · Answer 3 · 2013-10-28T20:30:00

Solution 3

Hello,
First of all, thank you for your help and quick response.
Secondary, Jochen Arndt I did as you told me but I am getting the error below:
Ping request could not find host d_↕. Please check the name and try again.
Press any key to continue . . .

Best Regards,
Victor

Posted 28-Oct-13 20:30pm

Vic.k

Comments

CPallini 29-Oct-13 2:53am

That has nothing to do with your original problem. This time, the command your program correctly issued, failed.

how to call system command with variable parameters

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0