An Issue with the RangeValidator Code

Question

0.00/5 (No votes)

See more:

I have a form that has 10 textboxes on it. 5 textboxes are auto populated from the database. the other 5 is for the user to enter numbers. I also have 5 rangevalidators on it. When I test the code I get an error. "Input string was not in a correct format. RangeValidatorLYTNFUG.MinimumValue = Convert.ToString(100 - Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);" What did I do wrong? Can someone please help?

C#

protected void Page_Load(object sender, EventArgs e)
    {
        ButtonPrint.Attributes.Add("onclick", "window.print(); return false");

        RangeValidatorLYTNFUG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) - Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);
        RangeValidatorLYTNFUG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) + Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);

        RangeValidatorLYTNFG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFG.Text) - Convert.ToInt32(TextBoxLYTNFG.Text) * 20 / 100);
        RangeValidatorLYTNFG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFG.Text) + Convert.ToInt32(TextBoxLYTNFG.Text) * 20 / 100);

        RangeValidatorLYTNCPUG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPUG.Text) - Convert.ToInt32(TextBoxLYTNCPUG.Text) * 20 / 100);
        RangeValidatorLYTNCPUG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPUG.Text) + Convert.ToInt32(TextBoxLYTNCPUG.Text) * 20 / 100);

        RangeValidatorLYTNCPG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPG.Text) - Convert.ToInt32(TextBoxLYTNCPG.Text) * 20 / 100);
        RangeValidatorLYTNCPG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPG.Text) + Convert.ToInt32(TextBoxLYTNCPG.Text) * 20 / 100);

        RangeValidatorLYTNNCC.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNNCC.Text) - Convert.ToInt32(TextBoxLYTNNCC.Text) * 20 / 100);
        RangeValidatorLYTNNCC.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNNCC.Text) + Convert.ToInt32(TextBoxLYTNNCC.Text) * 20 / 100);
        TextBoxFTUG.Focus();

ASP.NET

<td>
                <asp:RangeValidator ID="RangeValidatorLYTNFUG" runat="server" 
                    ControlToValidate="TextBoxTNFUG" CssClass="style40" 
                    ErrorMessage="Number is Higher/Lower than 20%" ForeColor="Red" Type="Integer"></asp:RangeValidator>
            </td>
        </tr>
        <tr>
            <td class="style30">
                2. Total Number (headcount) Full-Time Post-Baccalaureate Students</td>
            <td class="style26">
                <asp:TextBox ID="TextBoxLYTNFG" runat="server" Width="180px" 
                    ReadOnly="True" Enabled="False"></asp:TextBox>
            </td>
            <td class="style25">
                <asp:TextBox ID="TextBoxTNFG" runat="server" Width="180px"></asp:TextBox>
            </td>
            <td>
                <asp:RangeValidator ID="RangeValidatorLYTNFG" runat="server" 
                    ControlToValidate="TextBoxTNFG" CssClass="style40" 
                    ErrorMessage="Number is Higher/Lower than 20%" ForeColor="Red" Type="Integer"></asp:RangeValidator>
            </td>
        </tr>
        <tr>
            <td class="style30">
                3. Total Number (headcount) For-Credit, Part-Time Undergraduate Students</td>
            <td class="style26">
                <asp:TextBox ID="TextBoxLYTNCPUG" runat="server" Width="180px" 
                    ReadOnly="True" Enabled="False"></asp:TextBox>
            </td>
            <td class="style25">
                <asp:TextBox ID="TextBoxTNCPUG" runat="server" Width="180px"></asp:TextBox>
            </td>
            <td>
                <asp:RangeValidator ID="RangeValidatorLYTNCPUG" runat="server" 
                    ControlToValidate="TextBoxTNCPUG" CssClass="style40" 
                    ErrorMessage="Number is Higher/Lower than 20%" ForeColor="Red" Type="Integer"></asp:RangeValidator>
            </td>
        </tr>
        <tr>
            <td class="style30">
                4. Total Number (headcount) For-Credit, Part-Time Post-Baccalaureate Students</td>
            <td class="style26">
                <asp:TextBox ID="TextBoxLYTNCPG" runat="server" Width="180px" 
                    ReadOnly="True" Enabled="False"></asp:TextBox>
            </td>
            <td class="style25">
                <asp:TextBox ID="TextBoxTNCPG" runat="server" Width="180px"></asp:TextBox>
            </td>
            <td>
                <asp:RangeValidator ID="RangeValidatorLYTNCPG" runat="server" 
                    ControlToValidate="TextBoxTNCPG" CssClass="style40" 
                    ErrorMessage="Number is Higher/Lower than 20%" ForeColor="Red" Type="Integer"></asp:RangeValidator>
            </td>
        </tr>
        <tr>
            <td class="style30">
                5. Total Number (headcount) students enrolled in Non-Credit courses</td>
            <td class="style26">
                <asp:TextBox ID="TextBoxLYTNNCC" runat="server" Width="180px" 
                    ReadOnly="True" Enabled="False"></asp:TextBox>
            </td>
            <td class="style25">
                <asp:TextBox ID="TextBoxTNNCC" runat="server" Width="180px" AutoPostBack="True" 
                    ontextchanged="TextBoxTNNCC_TextChanged"></asp:TextBox>
            </td>
            <td>
                <asp:RangeValidator ID="RangeValidatorLYTNNCC" runat="server" 
                    ControlToValidate="TextBoxTNNCC" CssClass="style40" 
                    ErrorMessage="Number is Higher/Lower than 20%" ForeColor="Red" Type="Integer"></asp:RangeValidator>
            </td>
        </tr>
        <tr>
            <td class="style30">
                6. Total Headcount of All Students</td>
            <td class="style26">
                 </td>
            <td class="style25">
                <asp:TextBox ID="TextBoxTHCAS" runat="server" Width="180px" Enabled="False" 
                    ReadOnly="True"></asp:TextBox>
            </td>
            <td>
                 </td>
        </tr>
    </table>
    <br />

Posted 15-Nov-13 2:04am

Computer Wiz99

Updated 15-Nov-13 4:27am

v5

Add a Solution

Comments

♥…ЯҠ…♥ 15-Nov-13 8:15am

Hey, the line should be like this
RangeValidator1.MaximumValue = Convert.ToString(Convert.ToInt32(TextBox1.Text) + Convert.ToInt32(TextBox1.Text) * 20 / 100);
RangeValidator1.MinimumValue = Convert.ToString(Convert.ToInt32(TextBox1.Text) - Convert.ToInt32(TextBox1.Text) * 20 / 100);

Computer Wiz99 15-Nov-13 8:16am

Ok. So I don't have to set the control to validate?

♥…ЯҠ…♥ 15-Nov-13 8:25am

You have to set control to validate.. the above code is like to compute only maximum and minimum range for the range validator... if textbox1 has DB value 100 then ==> (100 + (100 *(20/100))) ==> (100 + 20) ==> 120 (20% + dbvalue 100) and for minimum value its (100 - 20%) = 80. Now you got it? Change the rangeValidator type to integer range validator properties window

Computer Wiz99 15-Nov-13 8:27am

Ok, so I don't have to set the range too, right?

♥…ЯҠ…♥ 15-Nov-13 8:28am

no we are setting range at page load only, so need to set range at design time.....

Computer Wiz99 15-Nov-13 8:42am

Are you still there?

Computer Wiz99 15-Nov-13 8:50am

This is still not working!!!! What is wrong with it????? Error Code"Input string was not in a correct format."

Computer Wiz99 15-Nov-13 8:23am

So, I am not doing anything to TextBox2?

♥…ЯҠ…♥ 15-Nov-13 8:28am

in rangevalidtor properties, set textbox2 as control to validate this alone textbox2 role is involved.dont forget to set rangevalidator type to integer by default its string.Then you will end up with this error "The MaximumValue XX cannot be less than the MinimumValue XX of
RangeValidatorUserID."

Computer Wiz99 15-Nov-13 8:30am

I have updated the code.

♥…ЯҠ…♥ 15-Nov-13 8:32am

still you are facing the error in code behind?

Computer Wiz99 15-Nov-13 8:33am

Have not tested it yet. Can you also look at the Forgot password send email to user b4 you go?

Computer Wiz99 15-Nov-13 8:36am

Still the same error. And I updated the code.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ron Beyer · Accepted Answer · 2013-11-15T02:10:00

Solution 1

You need to post your ASP page, but I'm guessing you didn't properly identify the type of validation you want to do, here is an example (from MSDN):

ASP

<asp:rangevalidator id="Range1" xmlns:asp="#unknown">
           ControlToValidate="TextBox1"
           MinimumValue="1"
           MaximumValue="10"
           Type="Integer"
           EnableClientScript="false"
           Text="The value must be from 1 to 10!"
           runat="server"/>
</asp:rangevalidator>

Note the "Type" parameter which is set to "Integer", if you have that set incorrectly, you will get an exception.

Full MSDN Example[^]

[Edit]
To see what part is failing, try this as the first operation in your method:

C#

int textInt1 = Convert.ToInt32(TextBoxLYTNFUG.Text);
int textInt2 = Convert.ToInt32(TextBoxLYTNFUG.Text);

RangeValidatorLYTNFUG.MinimumValue = Convert.ToString(textInt1 - textInt2 * 20 / 100);

But its apparent from the above that the MinimumValue will always be zero (you are subtracting the same value from itself, so that equals zero, zero times anything is zero, and zero divided by 10 is zero).

Anyway, try the above and I think you may find that your text in the textbox isn't being converted properly.

[Edit 2]

Here is what you should do to calculate your min/max values:

C#

int value = ;

RangeValidatorLYTNFUG.MinimumValue = ((int)(Convert.ToInt32(TextBoxLYTNFUG.Text) * 0.8f)).ToString();
RangeValidatorLYTNFUG.MaximumValue = ((int)(Convert.ToInt32(TextBoxLYTNFUG.Text) * 1.2F)).ToString();

Which is much cleaner than what you wrote :)

Posted 15-Nov-13 2:10am

Ron Beyer

Updated 15-Nov-13 5:08am

v4

Comments

Computer Wiz99 15-Nov-13 10:28am

Ron Beyer, Can you check my code and see where I went wrong?

Ron Beyer 15-Nov-13 10:34am

You should break down your pieces and see what part is throwing the error, it may have nothing to do with the validator but an invalid format for the Convert.ToInt32, I will update my answer to show how to see this.

Computer Wiz99 15-Nov-13 10:36am

The error says that the Input String was not in a correct format. Should I put the code after the auto populated textboxes?

Ron Beyer 15-Nov-13 10:39am

I updated the solution, try adding that at the top of your function and see where the error lies. What is the text in the TextBoxLYTNFUG?

Computer Wiz99 15-Nov-13 10:41am

They are all number in the database.

Ron Beyer 15-Nov-13 10:47am

Please try the above code and let me know where the error happens, if its during the Convert.ToInt32 or when you set MinimumValue.

Computer Wiz99 15-Nov-13 10:52am

Ok. I got this error now: "The value '' of the MaximumValue property of 'RangeValidatorLYTNFUG' cannot be converted to type 'Integer'." But that does have a value in the textbox. I took the old code and put it at the bottom of the auto populated code I have and it worked. The page loaded with no error but the rangevalidator did not fire when I put in different numbers that was higher than 0.

Ron Beyer 15-Nov-13 10:55am

Thats because, as I explained in my answer, you are subtracting a value from itself (the same textbox twice), so the MinimumValue is always going to be zero. Maximum value seems to be 2 times the textbox / 20 * 100, or 20% of twice the original value, which you could just re-write as textbox / 10 * 100.

Computer Wiz99 15-Nov-13 10:58am

Ok, So in this code: "RangeValidatorLYTNFUG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) - Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);
RangeValidatorLYTNFUG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) + Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);" I need to have two different textbox names to where it matches the textbox that the number is going to be what the user enters?

Ron Beyer 15-Nov-13 11:05am

I'm sorry, I see what the values are now, I forgot about order-of-operations

Here is what actually happens, lets suppose TextBoxLYTNFUG is 100...

20 / 100 = .2
100 * .2 = 20
100 - 20 = 80, so MinimumValue would be 80.

For Maximum, it would be:
20 / 100 = .2
100 * .2 = 20
100 + 20 = 120

So Minimum is 80 and maximum is 120, is this what you are going for?

You may be running into a conversion issue, if you are doing integer math 20/100 is not .2, its 0 (.2 rounded to the closest integer), so your minimum is zero and your maximum is the original value. You would have to re-write it as:

(TB = your textbox value)
Convert.ToInt32(TB) - Convert.ToInt32(TB) * (20.0f / 100.0f)

Hope that makes sense.

Ron Beyer 15-Nov-13 11:06am

I will update the solution to show how you should calculate your min/max values.

Computer Wiz99 15-Nov-13 11:25am

Hey Ron Beyer, You will not believe what I found out.

Ron Beyer 15-Nov-13 11:26am

...?

Computer Wiz99 15-Nov-13 11:33am

In the properties window for the validator, I had the Enabled "False". :)