First of all, please read this:
scope of variables[
^].
You don't need any global variable and
Select Case ... End Select
statement. Your query-string is wrong!
Private Sub cmbSortExecutives_Click()
Dim sqlString As String, sSort AS String
sqlString = "SELECT [Year], [OurDate], [LogID], [Subject], [Contact], [Director], [ADM], [DM], [Minister]" & vbcr & _
"FROM [Executive Correspondence]" & vbcr
sSort = "ORDER BY " & cmbSortExecutives.Value & " ASC;"
Me.lstViewExecutive.RowSource = sqlString
End Sub