sending bul email from site

Question

0.00/5 (No votes)

See more:

I am using ASP>NET with c#

I have a database named EmailData with three columns ID, UserName and Email which is collection of addresses of all usera of my site.
I am tryig to send an email to all the users from the site.

When i try to send to all the users, the email goes only to the first user, not to all users.

I am using the following code:

C#

protected void SendEmailButton_Click(object sender, EventArgs e)
    {
        string connectionString = ConfigurationManager.ConnectionStrings["EmailsConnectionString"].ConnectionString;
        using (SqlConnection connection = new SqlConnection(connectionString))
        {
            connection.Open();
            
            SmtpClient client = new SmtpClient("mail.mysite.com", 25);
            MailMessage mail = new MailMessage();

            mail.From = new MailAddress("info@mysite.com", "MY SITE");
            mail.To.Add(EmailTextBox.Text);

            SqlCommand command = new SqlCommand("SELECT Count(*) from EmailData", connection);
            int count = int.Parse(command.ExecuteScalar().ToString());

            for (int i = 0; i <= count; i++)
            {
                SqlCommand com1 = new SqlCommand("SELECT Email FROM EmailData", connection);
                string email = com1.ExecuteScalar().ToString();
                mail.Bcc.Add(email);
            }
            mail.Subject = SubjectTextBox.Text;

            mail.IsBodyHtml = true;
            mail.Body = MessageTextBox.Text;

            NetworkCredential mycredentials = new NetworkCredential("message@mysite.com", "mypassword");
            client.UseDefaultCredentials = false;
            client.Credentials = mycredentials;

            client.Send(mail);
            connection.Close();
        }
    }

I have not been able to figure out what is wrong with the loop that i am using that email goes only to one user.

Kindly help me.
Many thanks for your help.

Posted 2-Feb-14 3:42am

Member 10235977

Updated 2-Feb-14 6:34am

Richard MacCutchan

v2

Add a Solution

Comments

Richard MacCutchan 2-Feb-14 12:37pm

A bit of debugging should quickly show you what the value is of count, and what names get added to the Bcc field.

Member 10235977 2-Feb-14 15:25pm

I tried to get the value of count and BCC by adding a label. Count gives the totla number of records but the email simply repeats the first email address. the number of time it is repeated is eqaul to number of records. The output in my case was count = 150 and email label that i added haad the value like a@b.ca@b.ca@b.c and it is rep[eated 150 times if the first email address is a@b.c

JoCodes 2-Feb-14 12:38pm

Whats returned from "SELECT Email FROM EmailData"

Member 10235977 2-Feb-14 15:13pm

Email Address

Krunal Rohit 2-Feb-14 12:44pm

Just put a Breakpoint and see what is the value of count ?

Member 10235977 2-Feb-14 15:18pm

value of count is equal to the number of records in database. 150 in my case.

Member 10235977 2-Feb-14 15:35pm

For the sake of understanding i created a database with just 5 records and also added a label (Label1) to my code as follows
SqlCommand command = new SqlCommand("SELECT Count(*) from EmailData", connection);
int count = int.Parse(command.ExecuteScalar().ToString());

Label1.Text = count.ToString();

for (int i = 0; i <= count; i++)
{
SqlCommand com1 = new SqlCommand("SELECT Email FROM EmailData", connection);
string email = com1.ExecuteScalar().ToString();
mail.Bcc.Add(email);
Label1.Text += email;
}
mail.Subject = SubjectTextBox.Text;
The value of that Label1 returns is 5a@b.ca@b.ca@b.ca@b.ca@b.ca@b.c
first digit i.e. 5 is the nuber of records and the a@b.c is the first email address that is being repeated. Kinldy help me.

3 solutions

Solution 2

The issue is because of using com1.ExecuteScalar().ToString() inside the for loop which returns returns the first column of the first row in the result set.So each iteration in the loop fetches the same value from the query.

MSDN says

Quote:
Executes the query, and returns the first column of the first row in the result set returned by the query. Additional columns or rows are ignored.

So instead of ExecuteScalar method use DataReader so it iterates a through each email returned from the Query and Sends email.

DataReader[^]

Posted 2-Feb-14 18:47pm

JoCodes

Updated 2-Feb-14 18:49pm

v2

Solution 3

C#

SqlCommand com1 = new SqlCommand(SELECT Email FROM EmailData, connection);
               string email = com1.ExecuteScalar().ToString();
               mail.Bcc.Add(email);

This code always return the first rows.You have to put it in loop except the execute query.

C#

using (SqlDataReader dr = cmd.ExecuteReader())
  {
      while (dr.Read())
      {
          msg.CC.Add((string)dr[&quot;user_email&quot;]);
      }
  }

Posted 2-Feb-14 21:18pm

Ahmed Jubayer

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2014-02-02T18:37:00

Refer - SqlCommand.ExecuteScalar Method[^].