Stored procdure errors

Question

0.00/5 (No votes)

See more:

ALTER PROCEDURE Inventory
AS
BEGIN
INSERT INTO Inventory (FoodID, FoodName, ItemID, ItemName)
Select DISTINCT f.FoodID, f.FoodName, i.ItemID, I.Name from Food f CROSS JOIN Item i
WHERE f.FoodID=i.ItemID
END

How to avoid duplicate values of all.

Posted 4-Feb-14 18:04pm

hushhush1

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ravikhoda · Answer 1 · 2014-02-04T18:29:00

Solution 1

avoid cross join. try to use inner join or outer join if possible use primary/foreign key relation between two tables and do join with that particular column..

something like below

SQL

SELECT     Table1.column1 , Table2.column2
FROM         Table1 INNER JOIN
                      Table2 ON Table1 .column1= Table2.column2

Posted 4-Feb-14 18:29pm

ravikhoda

Comments

hushhush1 5-Feb-14 0:58am

But there are no common column between Food and Item table, I just want to insert foodID from Food and itemid from item into Inventory table

ravikhoda 5-Feb-14 1:06am

may be you can change your data structure then...

hushhush1 5-Feb-14 1:11am

nope I cannot change. Is there any other solution?

Ankur^\m/ · Answer 2 · 2014-02-04T18:32:00

Solution 2

Cross Join gives you all possible combinations of the two table. That is why you are getting duplicate rows. Check this - SQL Cross Joins[^].

You may want to use INNER JOIN[^] instead.

Posted 4-Feb-14 18:32pm

Ankur^\m/