Fuction calling problem

Question

1.40/5 (2 votes)

See more:

In this program , I have to make sure that the MAX_CAPACITY value is set to some proper value which is taken as an input from the user. This should be done only the first time when the Cache.GetMaxCapacity() is called. I am using custom console to get inputs from the user.

Program in Cache Class

C#

 private static int MAX_CAPACITY = 0;
                     
public static int GetMaxCapacity()
{
    if (MAX_CAPACITY == 0)
    {
        Console.WriteLine("Enter Max Capacity:");
        MAX_CAPACITY = CustomConsole.ReadInt();
    }

    Console.WriteLine("Returning MAX_CAPACITY");
    return MAX_CAPACITY;
}

Program in Main function

C#

Console.WriteLine("MAX_CAPACITY is " + Cache.GetMaxCapacity());

Console.WriteLine("MAX_CAPACITY is " + Cache.GetMaxCapacity());

Console.WriteLine("MAX_CAPACITY is " + Cache.GetMaxCapacity());

Console.ReadLine();

I solved the problem using the above code but I think it's not logical , the solution should be trickier and optimized. Help me on this.

Posted 22-Feb-14 18:32pm

JBobby

Updated 22-Feb-14 19:16pm

Maarten Kools

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 23-Feb-14 0:37am

Why do you think that trivial things should be trickier? Why do you think you need any optimization?
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

David_Wimbley · Accepted Answer · 2014-02-22T19:59:00

There really is no point in optimizing this but if your idea of optimization is less lines of code...here you go.

C#

//Usage
Console.WriteLie(MAX_CAPACITY == 0 ? "Enter Max Capacity:" : "Returning MAX_CAPACITY");
MAX_CAPACITY = GetMaxCapacity();

//"Refactored" code	
public static int GetMaxCapacity()
{
    return MAX_CAPACITY == 0 ? CustomConsole.ReadInt() : MAX_CAPACITY;
}