Mail Sending problem using smtp in C#

Question

0.00/5 (No votes)

See more:

I have done email notification system in my website in which user get email when they reach deadline..
but i encountered one problem that first user is receiving email that intended for him but second user is receiving 2 mails one that intended for him and another one is of previous user same way for 3rd user he will receive 3 mails and so on...
so for 1 user it will work perfect but when user increase it cause problem..
can anyone help me for finding error in below code because i'm unable to figure out what is wrong with code...

C#

public partial class Default2 : System.Web.UI.Page
{
 dbconnection db = new dbconnection();
    SqlDataReader dr;
    String senderAddress = string.Empty;
    String receiveraddress = string.Empty;
    String emailSubject = string.Empty;
    String emailMessageText = string.Empty;
    MailMessage mail = new MailMessage();
    SmtpClient client = new SmtpClient("smtp.gmail.com", 587);
    int Count = 0;
 protected void  Button1_Click(object sender, EventArgs e)
 {
           db.CheckStatus();

        DateTime ti= DateTime.Now;
        string format = "dd-MM-yyyy";
       
        string cmd = "select email,name,bname from book,student where book.stuid=student.enrollid AND book.duedate=('" + ti.ToString(format) + "')";    
       
 dr = db.RetriveData(cmd);                      //this works perfect
        
        while(dr.read())
        {

            Count++;
           
            senderAddress = "mymail@gmail.com";
            receiveraddress = dr[0].toString();
            emailSubject = " Book Duedate Reminder";
            emailMessageText = "Dear Mr " + dr[1].toString() + ". Today is duedate for book " + dr[2].toString() + ". So please return back to library otherwise you have to pay fine for late returning.Thank You.";

            mail.From = new MailAddress(senderAddress, "LibraryAdmin", System.Text.Encoding.UTF8);
            mail.To.Add(new MailAddress(receiveraddress));
            mail.Subject = emailSubject;
            mail.Body = emailMessageText;
           
            client.UseDefaultCredentials = false;
            client.Credentials = new NetworkCredential("mymail@gmail.com", "mypwd");
            client.EnableSsl = true;
            client.Send(mail);
           
            Label1.Text = "Mail Sent " + Convert.ToString(Count);


            TextBox1.Text += dr[0].toString() + "  " + dr[1].toString() + "  " + dr[2].toString() + "\n";           //here also it shows perfect 

            
        }
   }

[edit]Code block added - OriginalGriff[/edit]

Posted 7-Mar-14 21:27pm

Dean_Wi

Updated 7-Mar-14 21:44pm

OriginalGriff

v3

Add a Solution

3 solutions

Solution 2

C#

MailMessage emailmsg = new MailMessage();
        emailmsg.From = new MailAddress("abc@inc.com", "abc");
        emailmsg.To.Add(new MailAddress("cdf@inc.com", "cdf"));
        emailmsg.Subject = "Regarding Some information";
        emailmsg.Body = "stest bodcy";
        emailmsg.IsBodyHtml = true;
        emailmsg.Priority = MailPriority.Normal;
        SmtpClient mailclient = new SmtpClient("smtp.bizmail.yahoo.com");
        mailclient.Credentials = new System.Net.NetworkCredential("careers@inc.com", "123");
                
        mailclient.Send(emailmsg);

Posted 8-Mar-14 2:27am

ganeshbdas

Solution 3

see the following link
http://www.codeproject.com/Members/Member-9297053#_comments[^]

Posted 8-Mar-14 4:00am

Mahesh_Bhosale

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mehdi Gholam · Accepted Answer · 2014-03-08T02:02:00

Solution 1

Try creating a new mail message for each user instead of reusing the old one:

C#

...
        while(dr.read())
        {
           mail = new MailMessage(); // add this line
...

Posted 8-Mar-14 2:02am

Mehdi Gholam