error converting data type varchar to numeric

Question

0.00/5 (No votes)

See more:

C#

SqlCommand cmd = new SqlCommand("insert into patient_master values('" + Txt1.Text + "','" + Txt2.Text + "','" + TextBox1.Text + "','" + TextBox2.TextMode + "','" + TextBox3.TextMode + "','" + DropDownList1.Text + "','" + Textans.Text + "','" + email_id.Text + "','" + no.Text + "','" + txtarea1.TextMode + "')", sc);
            
sc.Open();

cmd.ExecuteNonQuery();

sc.close();

help me to solve this error

Posted 10-Mar-14 22:39pm

Member 10651903

Updated 10-Mar-14 22:50pm

Kornfeld Eliyahu Peter

v2

Add a Solution

Comments

SwarupDChavan 11-Mar-14 4:42am

Hey this seems to be a very simple problem there seems to be a column of int datatype in your sql table and you are passing the string value to it,just convert that string e.g convert.toint32(Txt2.Text).

Kornfeld Eliyahu Peter 11-Mar-14 4:50am

No. If string IS convertible SQL will do that...

SwarupDChavan 11-Mar-14 5:01am

can you explain?

Kornfeld Eliyahu Peter 11-Mar-14 5:17am

If the string contains '1344' SQL can cast it alone, you need not do that by yourself...
If it has 'abcc', even convert will not help - in fact it will fail...

JB0301 11-Mar-14 4:43am

Can you tell us the specifics of your database, maybe one of the columns you are trying to insert into is not matching with the ones in its database..

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kornfeld Eliyahu Peter · Answer 1 · 2014-03-10T22:54:00

It's obvious you pass some non numeric value to a numeric data column...

However you real problem is much worse that that! You are using string concatenation to create you query string! It's an invitation for SQL injection attack on your system!!!
Use parameterized queries! That will solve the injection problem and probably will point out the column in which you have the problem...
http://msdn.microsoft.com/en-us/library/system.data.sqlclient.sqlcommand.parameters(v=vs.110).aspx[^]

Kan07 · Answer 2 · 2014-03-11T00:51:00

Solution 2

I think you insert a string value to int field , i.e ..in your insert query for int "+ text.text +" and for string --- '"+ textb.text + "'

or int.Parse (textb.text)

Posted 11-Mar-14 0:51am

Kan07

error converting data type varchar to numeric

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us