Why search code not working....

Question

0.00/5 (No votes)

See more:

SQL-Server-2008

C#

private void cmdsearch_Click(object sender, EventArgs e)
{
    if (comboBox1.SelectedItem="ID")
    {
        SqlDataAdapter adp = new SqlDataAdapter("select * from test1 where id='" + textBox3.Text + "'", conn);
        DataTable tbl = new DataTable();
        adp.Fill(tbl);
        dataGridView1.DataSource = tbl;
    }
    else if (comboBox1.SelectedItem="Name")
    {
        SqlDataAdapter adp = new SqlDataAdapter("select * from test1 where name='" + textBox3.Text + "'", conn);
        DataTable tbl = new DataTable();
        adp.Fill(tbl);
        dataGridView1.DataSource = tbl;
    }
}

Posted 23-Mar-14 22:07pm

manish7664

Updated 24-Mar-14 1:10am

Marcin Kozub

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Raul Iloc · Accepted Answer · 2014-03-23T22:19:00

1.You should debug you application, inspect both SQL used in the SqlDataAdapter and copy the SQL commands and test them in you SQL server then you will see the error.
2.From your code I suspect that in you first SQL, where ID is used, the ID is an integer. If this is the case you should correct this SQL like in below:

C#

SqlDataAdapter adp = new SqlDataAdapter("select * from test1 where id=" + textBox3.Text, conn);

Better is to have a validation in your code and to try to convert the value to int before to send the user input to the SQL.
3.In the case of 2nd SQL also you should have a validation and to try to prevent the SQL injection attacks. Here is a MSDN link about.[^]