code enhancement on insert item to dropdownlist

Question

0.00/5 (No votes)

See more:

please review the code as below. the codes are all functioning, but too much of duplicate, anyway can simplified them?

C#

protected void Page_Load(object sender, EventArgs e)
{
       insertUser();
       insertCompany();
}

public void insertUser()
{
       List<ListItem> items = new List<ListItem>();
       ddlUser.Items.Clear();
       items = searchUser();
       ddlUser.Items.AddRange(items.ToArray());
}

public void insertCompany()
{
       List<ListItem> items = new List<ListItem>();
       ddlCompany.Items.Clear();
       items = searchCompany();
       ddlCompany.Items.AddRange(items.ToArray());
}

public List<ListItem> searchUser()
{
            List<ListItem> items = new List<ListItem>();
            // read user's table from sql and insert into 'items'
            return items;
}

public List<ListItem> searchCompany()
{
            List<ListItem> items = new List<ListItem>();
            // read company's table from sql and insert into 'items'
            return items;
}

please advice, thanks :)

Posted 6-Apr-14 23:10pm

melvintcs

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ArunRajendra · Accepted Answer · 2014-04-06T23:19:00

Original code.

C#

public void insertUser()
{
       List<listitem> items = new List<listitem>();
       ddlUser.Items.Clear();
       items = searchUser();
       ddlUser.Items.AddRange(items.ToArray());
}
</listitem></listitem>

Modified code

C#

public void insertUser()
{
       PopulateDropdown(ddlUser,searchUser());
}

private void PopulateDropdown(DropDownList ddl, List<listitem> items)
{
    ddl.Items.Clear();
    ddl.Items.AddRange(items.ToArray());
}
</listitem>