Blank Input Login Problem.

Question

1.00/5 (1 vote)

See more:

SQL-Server-2014

I'm facing some problems in my login system. If I put the correct information it says login successfully even if I input some wrong info it says "Your username or password is incorrect. Please try again." Now the problem is if doesn't put anything on the username and password field and hit the Login Button... it also Logins successfully... I'm not getting how to fix this weird error. Please Someone help me out from this.

C#

private void btnLogin_Click(object sender, EventArgs e)
        {
            try
            {
                //Connecting Database form SqlDbConnect.cs Class
                con = new SqlDbConnection();
                con.SqlQuery("select * from LookDB.dbo.Users where UserName='" + this.username_txt.Text + "' and Password='" + this.password_txt.Text + "' ;");
                SqlDataReader Reader;
                Reader = con.cmd.ExecuteReader();
                int count = 0;
                while (Reader.Read())
                {
                    count = count + 1;
                }
                if (count == 1)
                {
                    MessageBox.Show("Successfully Login. Press OK to Continue", "Login Successful", MessageBoxButtons.OK, MessageBoxIcon.None);
                    this.Hide();
                    MainWindow newForm = new MainWindow();
                    newForm.ShowDialog();
                }
                else if (count > 1)
                {
                    MessageBox.Show("Access Denied!");
                }
                else
                    MessageBox.Show("Your username or password is incorrect. Please try again.", "Warning", MessageBoxButtons.RetryCancel, MessageBoxIcon.Warning);
            }
                catch (Exception ex)
                {
                    MessageBox.Show(ex.Message);
                }
        }

Posted 16-May-14 12:18pm

User 10744971

Add a Solution

Comments

[no name] 16-May-14 18:37pm

So check and see if username_txt.Text or password_txt.Text are empty before you do anything and if they are, simply return.

mufeed k 16-May-14 21:53pm

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;
using System.Data;
using System.Data.SqlClient;
namespace WindowsFormsApplication1
{
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
}
SqlConnection con;
SqlDataAdapter da;
SqlCommand cmd;
DataTable dt;

private void Form1_Load(object sender, EventArgs e)
{

}

private void button1_Click(object sender, EventArgs e)
{
con = new SqlConnection("your coonection string");
cmd=new SqlCommand ();
cmd.Connection = con;
con.Open();
cmd.CommandText = "select query";
da = new SqlDataAdapter();
da.SelectCommand = cmd;
dt = new DataTable();
da.Fill (dt);
if (dt.Rows.Count > 0)
{
MessageBox.Show("Login succesfull");
}
else
{
MessageBox.Show("Invalid username or password");
}

}
}
}

2 solutions

Solution 2

do proper validation on your button click

like

if txtusername.text.trim="" or txtpassword.text.trim="" then
msgbox("Enter yousername and password")

else
your login check code
end if

Posted 16-May-14 15:43pm

mufeed k

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mandip Grewal · Accepted Answer · 2014-05-16T16:58:00

Solution 3

Your code seems to be correct. Please ensure that there is no record in your database with blank username and password.

Please use RequiredFieldValidator on textboxes to ensure that form doesn't submit with no input.

Posted 16-May-14 16:58pm

Mandip Grewal

Comments

[no name] 17-May-14 10:17am

Thanks dude, and yes there was a record in my database with blank username and password. LoL..