warning : Possible unintended reference comparison

Question

0.00/5 (No votes)

See more:

C#

for (int j = 0; j <= ttarray.Length; j++)
            {
                foreach(DataRow dr in dt.Rows)
                {
                    row++;

                    foreach(DataColumn dc in dt.Columns)
                    {
                        col++;

                        if ((dr["DayName"].ToString()==ttarray[j].DayName) && (dc.ColumnName == ttarray[j].HourName))
                        {

                            string FullName = ttarray[j].LastNameFaculity +" "+ttarray[j].FirstNameFaculity;
                            string week;

                            dt.Rows[row][col] = FullName + ttarray[j].LessonName + week;
                        }
                    }

                }

            }

warning : Possible unintended reference comparison; to get a value comparison, cast the left hand side to type 'string' (dr["DayName"].ToString()==ttarray[j].DayName)

Posted 28-Aug-14 20:50pm

Member 10728784

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-08-28T21:07:00

I can't see a good reason for that error, but I'd try moving the code about a bit:

C#

for (int j = 0; j <= ttarray.Length; j++)
{
    foreach(DataRow dr in dt.Rows)
    {
        row++;
        string dayName = dr["DayName"].ToString();

        foreach(DataColumn dc in dt.Columns)
        {
            col++;

            if ((dayName==ttarray[j].DayName) && (dc.ColumnName == ttarray[j].HourName))
            {

                string FullName = ttarray[j].LastNameFaculity +" "+ttarray[j].FirstNameFaculity;
                string week;

                dt.Rows[row][col] = FullName + ttarray[j].LessonName + week;
            }
        }

    }

I'd probably also extract the ttarray[j] to a named class instance:

C#

MyClass whateverThisIsSupposedToBe = ttarray[j];

And use the name throughout instead. (The optimiser will probably do that for you, but it makes the code a little more readable)

That may remove the error.

}