Conversion failed when converting datetime from character string.

Question

0.00/5 (No votes)

See more:

Hello my friends,
I have this code

C#

protected void Calendar1_SelectionChanged(object sender, EventArgs e)
        {
            myda = new SqlDataAdapter("Select * from News where NewsDate='" +  Calendar1.SelectedDate.ToString() + "'", mycn);
            dsSelDate = new DataSet();
            myda.Fill(dsSelDate, "AllTables");
            if (dsSelDate.Tables[0].Rows.Count == 0)
            {
                DataGrid1.Visible = false;
            }
            else
            {
                DataGrid1.Visible = true;
                DataGrid1.DataSource = dsSelDate;
                DataGrid1.DataBind();
            }
        }

when I run this code give me the following error

Conversion failed when converting datetime from character string.
any body help !!

Posted 4-Sep-14 1:15am

Ahmed Sa3d

Add a Solution

2 solutions

Solution 2

Simple: Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

C#

myda = new SqlDataAdapter("Select * from News where NewsDate=@DT", mycn);
myda.SelectCommand.Parameters.AddWithValue("@DT", Calendar1.SelectedDate);
dsSelDate = new DataSet();
myda.Fill(dsSelDate, "AllTables");

Posted 4-Sep-14 1:35am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

*Suvabrata Roy* · Accepted Answer · 2014-09-04T01:32:00

Solution 1

Hi,

By Default SQL Server will follow MM/DD/yyyy so first check what is your Controls date format.

Now you can change the format of date in SQL Server by DATEFORMAT[^]

Tip :

Always use date format as DD-MMM-yyyy (e.g 04-Sep-2014)

Thanks
Suvabrata

Posted 4-Sep-14 1:32am

Suvabrata Roy