How to update two table in asp.net

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

I want to update my status from '2' to '3', but my problem is data not update in database

VB

Sub Update()    'UPDATE RECORD

        Dim strIDK As String = Me.txtIdKaunseling.Text

        If strIDK = "" Then Exit Sub

        If strIDK <> "" Then
            '---UPDATE IN TABLE SKP01_KaunselingPL---
            sql = "UPDATE dbo.SKP01_KaunselingPL SET SKP01_Status = '3' " _
                & "WHERE SKP01_KaunselingID = '" & strIDK & "'"

            If fnExec(sql, iTran:=2) = 1 Then
                setMsg(Me, msgBoxSaved, "strKey1")
            Else
                setMsg(Me, msgBoxSaveFailed, "strKey1")
            End If

            '---UPDATE IN TABLE SKP01_KaunselingDT---
            sql = "UPDATE dbo.SKP01_KaunselingDT SET SKP01_Status = '3'" _
                & "WHERE SKP01_KaunselingID = '" & strIDK & "'"

            If fnExec(sql, iTran:=2) = 1 Then
                setMsg(Me, msgBoxSaved, "strKey1")
            Else
                setMsg(Me, msgBoxSaveFailed, "strKey1")
            End If
        End If
    End Sub

This is my btnSave HTML

ASP.NET

<div id="menu" class="toolbar">
        <asp:ImageButton ID="ImageButton1" runat="server" ImageUrl="~/Images/save.png" ToolTip="Save" CssClass="imgBtn" ValidationGroup="Check" Width="32" Height="32"/>                
    </div>

Posted 24-Sep-14 18:58pm

U_Hanisa

Updated 28-Sep-14 16:02pm

v4

Add a Solution

Comments

Sinisa Hajnal 25-Sep-14 2:21am

Several problems with this code:
- if your Session("strID") is an empty string CInt will throw an exception
- your update code shouldn't be concatenated, use parametrized query
- if your IDs are numbers, don't use chars / varchars
- if your statuses are numbers, use number columns not chars / varchars (you can even create STATUS table so you get number AND description as you need them while maintaining simple integer FK.

Finally, you didn't really pose a question here, what is your problem? Which error do you get? At which line? Or your code works, but doesn't remove the row from the grid?

U_Hanisa 25-Sep-14 2:33am

Yes, that is my problem. I don't know what error in my coding. But when I click btnSave, it doesn't remove from the gridview. Can you help me?

Sinisa Hajnal 25-Sep-14 2:46am

No, I can't. There is no btnSave in your code above, nor the handler for the same (unless you bind to Update).

I could if you provide more details.
If you check my first item from the last comment, you'll see that you get an error in CInt(Session("strID")) OR that your Session("strID") is NOT an empty string :)

Set a break point at If Session("strID") line, remove any catch handlers that "swallow" the errors, let the errors be seen.

Update your question - provide description of the intent of the code - what should be in strID? Where do you set it? Why do you test for empty string before going into saving block?

U_Hanisa 25-Sep-14 2:55am

btnSave is Sub Update. Pls check my updated question. I don't understand what are you trying to say.

Sinisa Hajnal 25-Sep-14 3:08am

OK. Slow and easy, answer each question, then we will proceed:
- Do you know what a breakpoint is? And how to set it?
- Do you have any try/catch blocks?
- Can you update your question with your btnSave HTML?
- Does saving the status work? That is, if you click btnSave, does it change in the database? Or none of it works? (this would be my guess)

- What should be stored in Session("strID")?
- Why are you testing it to be empty before saving? That is, what do you think If Session("strID") = "" does?

U_Hanisa 25-Sep-14 3:23am

Oh, I see. My btnSave is Sub Update actually. The value of Session("strID") = "" is when I select one of ID in gridview. After I click cmdSelect in gridviw,it will display the data at the screen then I click btnSave to change the status to '3'. Now, the problem is when I click btnSave(Sub Update), status doesn't change at database, and the data still display in the gridview. Do you get what I mean?

Sinisa Hajnal 25-Sep-14 3:27am

Yes, but that doesn't answer other questions.

Your saving code will NEVER execute the way the function stands. Please take some time to answer the questions. I'm trying to resolve the problem, but also you need to learn from it. And by NOT giving me answers you're actually prolonging this. Thank you.

U_Hanisa 25-Sep-14 3:36am

How could I know if I ask the question here. It's ok if it hard to you to help me. My english is not very good, so I'm sorry because I don't know how to explain to you. Thank you too. You showed me that you're hot tempered^^

Sinisa Hajnal 25-Sep-14 3:40am

no, no, your question is good enough as is your english. But you have to put SOME effort into answering your question and you're not doing it. I cannot read your mind nor see your screen, YOU have to answer the questions that I cannot.

You don't have to know what is wrong with the function, I'm asking you what do you think, not what it really does. Also, asking do you know how to debug, has nothing to do with your problem, please don't get upset and we will have this finished in no time.

I've put more time into this question then many others, I'd say I was very patient with you, not hot tempered :). See my initial solution, we'll improve it once you calm down and answer the questions.

U_Hanisa 25-Sep-14 4:01am

Ok sorry. Actually, I don't really get what do you mean.
-First, I know what a breakpoint and how to set it.
-Second, I don't have any try/catch blocks because I don't know.
-Third, I'd update my question with btnSave HTML
-Fourth, the saving status doesn't work and didn't change in the database.
-Session("strID") is empty because ID is changing depends on user choice.
And for your information,I'm still an amateur in programming. I'm learning now.

Sinisa Hajnal 25-Sep-14 4:07am

That is why I'm helping you :)

OK. Now that we're talking again: where do you set Session("strID")? If the user clicks select?

Put breakpoint at the IF line in your Update function and try to save...you can check the value of Session("strID") before continuing. Let me know what it is. With F10 (assuming visual studio) you can execute only that one line and see if it enters saving part.

When we're done, read about try-catch, you'll need some around database handling code in case the connection is lost or some other issue occurs. Unless you're handling that in fnExec...also read about finally block where your can close your connections and destroy command objects.

U_Hanisa 25-Sep-14 4:38am

I don't set Session("strID") anywhere, and when I use breakpoint, the Session("strID") didn't give the value. Haha, you're right. So what I'm going to do?

Sinisa Hajnal 25-Sep-14 4:42am

You have to set it when the user selects the row that is when cmdSelect is clicked. Did you consider simply having save button in each row? That way you could use CommandArguments for the buttons.

U_Hanisa 28-Sep-14 22:02pm

Please check my updated question

Sinisa Hajnal 29-Sep-14 2:07am

You don't need "If strIDK <> "" Then" since you're checking that it is empty line before and exiting. You should use Return instead of Exit Sub which is "old VB way" of doing exit.

The code looks correct now, do you have any further trouble?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sinisa Hajnal · Answer 1 · 2014-09-24T21:45:00

First of all, the function Update will never get past

VB

If Session("strID") = ""

if Session("strID") is set to some value because this line asks if strID is NOT set...

You need to change that first "if" to:

VB

If Session("strID") IsNot Nothing AndAlso IsNumeric(Session("strID")) Then
' the rest of your function
End If

This checks that strID exists in your session and that it is a number (or CInt function would throw an error)