Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index

Question

1.67/5 (8 votes)

See more:

I've used similar code before.. but this is stumping me right now. No matter what I try I'm getting the same error (Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index). I'm trying to pull data with the second query to add to my results table. The line that is throwing the error is: res_bom[doc_item.IndexOf(p)] = onbom;

           List<string> doc_item = new List<string>();
           List<int> doc_qty = new List<int>();
           List<int> doc_qty_rem = new List<int>();
           List<decimal> doc_minprice = new List<decimal>();
           List<decimal> doc_maxprice = new List<decimal>();
           List<string> res_bom = new List<string>();
             this.cimDocumentDetailTableAdapter.FillByDoc(this.dsTools.cimDocumentDetail, doc);
           foreach (DataRow dr in this.dsTools.cimDocumentDetail.Rows)
           {
               doc_item.Add(dr.ItemArray[1].ToString());
               doc_qty.Add(int.Parse(dr.ItemArray[2].ToString()));
               doc_qty_rem.Add(int.Parse(dr.ItemArray[2].ToString()));
               doc_minprice.Add(decimal.Parse(dr.ItemArray[9].ToString()));
               doc_maxprice.Add(decimal.Parse(dr.ItemArray[10].ToString()));
               res_bom.Add("");
               res_oocust.Add(0);
           }

{
               string q = @"
                       SELECT LTRIM(RTRIM(CPN_I)) as 'Part', 'Yes' AS Expr1    FROM   bm010115 AS bm010115_1
                       WHERE (CPN_I like '10-C%') and (CPN_I not like '10-C%C') ORDER BY 'PART'";
               DataTable data = ExecuteQuery("Tools", q);
               foreach (DataRow dr in data.Rows)
               {
                   string p = dr.ItemArray[0].ToString();
                   string onbom = dr.ItemArray[1].ToString();
                   try
                   {
                       res_bom[doc_item.IndexOf(p)] = onbom;
                   }
                   catch (SqlException ex)
                   {
                       MessageBox.Show(ex.Message);
                   }
               }
           }

Any help would be greatly appreciated

Posted 25-Sep-14 7:36am

dae0c

Updated 25-Sep-14 7:39am

v2

Add a Solution

Comments

[no name] 25-Sep-14 13:49pm

Well debug your code, find the index that is less than zero or greater than the number of elements in your array.

dae0c 25-Sep-14 14:03pm

I've debugged, I just can't comprehend where the problem lies. Amateur coder at best here...

SS

Sergey Alexandrovich Kryukov 25-Sep-14 14:18pm

Why, why showing bitmaps trying to ask or clarify questions? Isn't so difficult to present all information in text, which anyone can copy, perform text search, and so on?
Please, do this favor to everyone, avid it.
—SA

dae0c 25-Sep-14 14:19pm

It's not a bitmap, and it's in text above. Just highlighting to show what I see in VS. But thank you very much for your input.

Sergey Alexandrovich Kryukov 25-Sep-14 15:53pm

It is a bitmap. I mean what we see in SS. RDdgTEy.jpg is a bitmap. Functionally, there is no a text, there are pixels. I hope you understand what I mean. It's inconvenient to use, people cannot select text, copy, do search...
—SA

[no name] 25-Sep-14 14:28pm

What do you mean you do not comprehend? The error message is telling you exactly what the problem is. You are trying to access an element of an array with an index that is less than 0 or greater than the size of the array.

dae0c 25-Sep-14 14:46pm

Because my data.Rows does not have zero rows, it has about 2000. It is showing that data when I debug

[no name] 25-Sep-14 14:52pm

And what does that have to do with the error? You are trying to access an element of an array that does not exist. So you are either trying to access your array with an index of -1 or an index greater than "about 2000".

dae0c 25-Sep-14 15:09pm

Just going off the "solution" below. Am I not defining the array correctly (so that it does not exist)? VS can see the data I am trying to pull while debugging.

[no name] 25-Sep-14 15:21pm

What? I am not sure what is getting lost in translation here. Arrays have boundaries. You access the elements of an array using an index (number). array[0] is the first element, array[1] second element, etc. You are attempting to access an element of an array using an index that is outside the bounds of the array. What that is we can't tell you because we do not have your data. You need to find out what index you are using that is causing the error. You need to step through your code and check the indexes that you are using.

LLLLGGGG 25-Sep-14 14:12pm

In which line is the problem? I.E. Which line does your C# compiler throw the exception?

LG

dae0c 25-Sep-14 14:18pm

res_bom[doc_item.IndexOf(p)] = onbom;

you can click "SS" above to see a screen shot

Sergey Alexandrovich Kryukov 25-Sep-14 14:19pm

This is not what you've shown on that picture. Is that so hard to include all relevant information in the question from the very beginning?
—SA

dae0c 25-Sep-14 14:22pm

I did not present any new information in that picture. res_bom[doc_item.IndexOf(p)] = onbom; is in my original post. As is this line: "The line that is throwing the error is: res_bom[doc_item.IndexOf(p)] = onbom;"

I don't know why you are being a dick but you can go do it somewhere else if you don't want to help..

Sergey Alexandrovich Kryukov 25-Sep-14 14:27pm

Not exactly. Compare with your comment.

Wait a minute...

Are you trying to be rude with me? You have problems with very basic problems which you should really solve by yourself and talk to a person who actually posted a question and patiently trying to sort out your mess. And then you in fact are trying to tell me "shut up"? Who is going to deal with you, if one can see such behavior?

—SA

dae0c 25-Sep-14 14:29pm

If someone is rude to me I have no problem being rude back. "Don't dish it out if you can't take it" comes to mind.

2 solutions

Solution 2

I can't tell you what is wrong, but I will say that I do not put functions inside my square brackets for this very purpose. Here is how I would debug this code. Put this in your "try" block.

int x = doc_item.IndexOf(p);
if (x >= 0 && x < res_bom.Count())
{
   res_bom[x] = onbom;
}
else
{
   MessageBox.Show("res_bom has " + res_bom.Count().ToString() + 
           " items and you are looking for number " + x.ToString();
}

Posted 26-Sep-14 7:53am

dbrenth

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2014-09-25T08:16:00

Isn't that obvious? If data.Rows has zero rows, the first statement in loop will throw this exception, because the element dr.ItemArray[0] does not exist. If data.Rows has only one row, the second statement in loop will throw this exception, because the element dr.ItemArray[1] does not exist.

As to "amateur coder at best", yes, the attempt to work with strings representing the data instead data itself, hard-coded strings and indices tells the tale… :-)

[EDIT]

You are give contradictory information in code, screenshot (why doing it at all?) and comment. In all other cases, do the same thing: put a break point at the assignment which throws the exception, examine an index, compare with the number of elements in the set being indexed. Then find out why index is beyond 0..N−1, where N is the number of elements.

—SA