How to get data related to the Id using generic list

Question

1.00/5 (1 vote)

See more:

Quote:

Hi I have this scenario,
These are my tables

1. Room  
   =====
   RoomId    RoomName
   1         Iphone
   2         Samsung
   3         Nokia

2. RoomImage
   =========
   RoomImageId RoomId NormalImage
   1           1       iphone1.jpg
   2           1       iphone2.jpg
   3           1       iphone1.jpg
   4           2       Samsung1.jpg
   4           2       Samsung2.jpg
   4           2       Samsung3.jpg

And this is my code :

public static List<roominfo> LoadAllRoomDetails()
        {
            try
            {
                
                List<roominfo> lstRooms = RoomInfo.GetRooms();
                List<roomimage> lstRoomImages = new List<roomimage>();
                
                foreach (var items in lstRooms)
                {
                    RoomInfo _RoomInfo = new RoomInfo();                
                    _RoomInfo.RoomTitle = items.RoomTitle;
                    _RoomInfo.RoomName = items.RoomName;
                    _RoomInfo.RoomPrice = items.RoomPrice;
                    _RoomInfo.RoomId = items.RoomId;
                    _RoomInfo.RoomDescription = items.RoomDescription;

                    RoomImage _RoomImage = new RoomImage();
                    _RoomImage.RoomId = _RoomInfo.RoomId;
                    var LstOfImages = _RoomImage.GetRoomImagesByRoomId();

                    
                    foreach (var images in LstOfImages)
                    {
                        _RoomImage.RoomImageId = images.RoomImageId; 
                        _RoomImage.NormalImage = images.NormalImage;
                        _RoomImage.LSTImages = LstOfImages;
                        lstRoomImages.Add(_RoomImage);
                    }
                    
                    
                    lstRooms.Add(_RoomInfo);
                    
                }
                
                return lstRooms;
            }
            catch (Exception)
            {

                throw;
            }

And this is the code inside the method GetRoomImagesByRoomId();

C#

public IEnumerable<roomimage> GetRoomImagesByRoomId()
        {
            using (SqlDataReader sdr = SqlHelper.ExecuteReader(SqlHelper.GetConnection(), "[GetRoomImagesByRoomId]", RoomId))
            {
                if (sdr.HasRows)
                {
                    while (sdr.Read())
                    {
                        yield return new RoomImage
                        {
                            RoomId = Convert.ToInt32(sdr["RoomId"]),
                            RoomImageId = Convert.ToInt32(sdr["RoomImageId"]),
                            ThumbnailImage = Convert.ToString(sdr["ThumbnailImage"]),
                            NormalImage = Convert.ToString(sdr["NormalImage"])
                        };
                    }
                }
            }
        }

Now am trying to use generic list to get the RoomImages related to it RoomId.
So the problem is on that line:
RoomImage _RoomImage = new RoomImage();
means everytime the loop is creating a new object on that line means it is not storing the list of the previous Images, it is storing only the current one in the loop.
Please could you help how can I resolve that issue?

Posted 13-Oct-14 4:40am

El Dev

Updated 13-Oct-14 4:44am

v3

Add a Solution

Comments

BillWoodruff 13-Oct-14 13:27pm

I don't have time to study your code, but I have one immediate response: why not build a Dictionary<roominfo,List<lstRoomImages>> ?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Prasad Avunoori · Answer 1 · 2014-10-13T18:39:00

C#

  public IEnumerable<roomimage> GetRoomImagesByRoomId()
        {
            using (SqlDataReader sdr = SqlHelper.ExecuteReader(SqlHelper.GetConnection(), "[GetRoomImagesByRoomId]", RoomId))
            {
                IEnumerable<roomimage> lstRoomImage = new IEnumerable<roomimage>();
                RoomImage objRoomImage = new RoomImage();
                if (sdr.HasRows)
                {
                    while (sdr.Read())
                    {
                        yield return new RoomImage
                        {
                            objRoomImage.RoomId = Convert.ToInt32(sdr["RoomId"]),
                            objRoomImage. RoomImageId = Convert.ToInt32(sdr["RoomImageId"]),
                            objRoomImage. ThumbnailImage = Convert.ToString(sdr["ThumbnailImage"]),
                            objRoomImage.NormalImage = Convert.ToString(sdr["NormalImage"])
                            lstRoomImage.Add(objRoomImage);
                        };
                    }
                }
            }

            retrun lstRoomImage;
        }
</roomimage></roomimage></roomimage>