Add data to a list with out replacing the old value

Question

0.00/5 (No votes)

See more:

I have a list 'objlistCropped' and when i tried to add values to this list using a foreach loop all the list value is replaced by last value.

C#

string strCroppedImagePaths = @"C:\CropImages";
            Selected objCropped = new Selected();
            Source objSource = new Source();
            ArrayList listCropped = new ArrayList();
            DirectoryInfo d = new DirectoryInfo(strCroppedImagePaths);

         FileInfo[] file = d.GetFiles("*.Jpeg").OrderBy(fi => int.Parse(Path.GetFileNameWithoutExtension(fi.Name).TrimStart("Image".ToArray()))).ToArray();
            DataTable dt = new DataTable();
            int RowID = 0;

            foreach (FileInfo file2 in file)
            {
                if (file2.Extension == ".jpg" || file2.Extension == ".Jpeg" || file2.Extension == ".gif" || file2.Extension == ".png" || file2.Extension == ".bmp")
                {
                    //listCropped.Add(file2);
                    string strCroppedImagename = file2.Name;
                   
                    RowID++;
                    
                    objCropped.Image = strCroppedImagename;
                    objlistCropped.Add(objCropped);
                }
            }

if folder having 10 images, all the list values are last image (Image10).

Posted 20-Jan-15 3:45am

Renjith_R

Updated 20-Jan-15 3:50am

v5

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Leo Chapiro · Answer 1 · 2015-01-20T03:57:00

You wanted to write this one surely (just a typing error):

C#

//listCropped.Add(file2);
 foreach (FileInfo file2 in file)
 {
      if (file2.Extension == ".jpg" || file2.Extension == ".Jpeg" || file2.Extension == ".gif" || file2.Extension == ".png" || file2.Extension == ".bmp")
            //string strCroppedImagename = file2.Name;
            string strCroppedImagename = file.Name;

BillWoodruff · Answer 2 · 2015-01-20T23:54:00

Your code does not show where 'objlistCropped is defined, but, assuming it is a List of Type 'Selected:

1. The error occurs because you are re-using the same instance of a Selected, 'objCropped, each time: 'objCropped is clearly a reference Type.

2. You can fix this, I am pretty sure, by just creating a new Instance of 'Selected to add each time you update the List:

C#

objCropped = new Selected();
objCropped.Image = strCroppedImagename;
objlistCropped.Add(objCropped);

Of course, if you used this approach, then you could declare 'objcropped at the start of your code without initializing it.

Add data to a list with out replacing the old value

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0