how to escape single quotes in a dynamic SQL clause?

Question

0.00/5 (No votes)

See more:

Hello,

I have an insert query in my application (vb.net 3.5; Oracle 10g)

Dim queryString As String = "insert into metadata (OBJECT_NAME, TITLE, ROW_NUM1) values ('" + strObjName + "', '" + strTitle + "', myDB.SEQ_ID.NEXTVAL)"

The title column at times have words having a apostrophe. While trying to insert these values am getting the error -

ORA-01756 quoted string not properly terminated

Can anyone tell me how to escape this?

Thank you!

Posted 4-Feb-15 3:15am

Member 11194850

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Peter Leow · Accepted Answer · 2015-02-04T03:30:00

Solution 1

You can avoid such a hassle by parameterize your sql query, refer: VB.NET: convert text with single quote to upload to Oralce DB[^]

Posted 4-Feb-15 3:30am

Peter Leow

Updated 4-Feb-15 3:31am

v2

Thomas Daniels · Accepted Answer · 2015-02-04T03:35:00

You can escape it by replacing the single quote by two single quotes: ''.

However, I suggest to use a parameterized query instead of escaping the string. Why? Because if you use string concatenation (like you do now) to create your command, you are not protected against SQL Injection[^]. You can use named parameters like this:

VB.NET

Dim queryString As String = "insert into metadata (OBJECT_NAME, TITLE, ROW_NUM1) values (:objName, :title, myDB.SEQ_ID.NEXTVAL)"
Dim command As OracleCommand = New OracleCommand(query, connection) ' replace connection by the name of the variable of your OracleConnection
command.CommandType = CommandType.Text
command.Parameters.Add(":objName", OracleDbType.Varchar2).Value = strObjName
command.Parameters.Add(":title", OracleDbType.Varchar2).Value = strTitle