Collection Of List in c#

Question

0.00/5 (No votes)

See more:

C#

public static List<spectrumitem> GetSpectrumBandStartValue(SqlConnection nodeDbCon, uint Starttime)
        {
            List<spectrumitem> SpectList = new List<spectrumitem>();
         
                int cid = 0;
                uint st = 0;
                int pid = 0;
                int bs = 0;
                int tresh = 0;
                short dwl = 0;
                short corl = 0;
                int sp = 0;
                SqlCommand cmd = new SqlCommand();
                cmd.Connection = nodeDbCon;
                cmd.Parameters.Add("@StartTime", SqlDbType.Int).Value = Starttime;
                cmd.CommandType = CommandType.StoredProcedure;
                cmd.CommandText = "dbo.usp_GetSpectrumBandStart";
                SpectrumItem SpectrumItem = new SpectrumItem(st, pid, bs, tresh, dwl, corl, sp,cid);
                DataTable dt = new DataTable();
                SqlDataAdapter da = new SqlDataAdapter(cmd);
                da.Fill(dt);
                foreach (DataRow cdr in dt.Rows)
                {
                    st = Convert.ToUInt32(cdr[0]);
                    bs = Convert.ToInt32(cdr[1]);
                    pid = Convert.ToInt32(cdr[2]);
                    cid = Convert.ToInt32(cdr[3]);
                    SpectList.Add(SpectrumItem);
                }
             
            return SpectList;
                
        }

When i execute the code everything runs good,list item count is 230.. but all list values of 230 is 0.. How to add the values to list.. Please help me

Posted 10-Feb-15 0:02am

Rnshanmugavadivel

Updated 10-Feb-15 0:03am

Kenneth Haugland

v2

Add a Solution

2 solutions

Solution 2

Um.
Why are you adding the same item each time?
You create one instance of a SpectrumItem:

C#

SpectrumItem SpectrumItem = new SpectrumItem(st, pid, bs, tresh, dwl, corl, sp,cid);

with all zero values, and then you add it repeatedly without changing it:

C#

foreach (DataRow cdr in dt.Rows)
{
    st = Convert.ToUInt32(cdr[0]);
    bs = Convert.ToInt32(cdr[1]);
    pid = Convert.ToInt32(cdr[2]);
    cid = Convert.ToInt32(cdr[3]);
    SpectList.Add(SpectrumItem);
}

I suspect that what you actually want to do is this:

C#

foreach (DataRow cdr in dt.Rows)
{
    st = Convert.ToUInt32(cdr[0]);
    bs = Convert.ToInt32(cdr[1]);
    pid = Convert.ToInt32(cdr[2]);
    cid = Convert.ToInt32(cdr[3]);
    SpectrumItem SpectrumItem = new SpectrumItem(st, pid, bs, tresh, dwl, corl, sp,cid);
    SpectList.Add(SpectrumItem);
}

And remove the earlier instance completely.

Posted 10-Feb-15 0:08am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kornfeld Eliyahu Peter · Accepted Answer · 2015-02-10T00:07:00

The problem is with/around your loop...
What you do is:
1. Create a variable named SpectrumItem (outside the loop)
2. Run a loop, in which you update several variables and add the SpectrumItem variable to the list (the VERY SAME each time)

What you have to do is:
1. Run a loop, and add a newly created SpectrumItem in each iteration...

C#

foreach (DataRow cdr in dt.Rows)
{
  st = Convert.ToUInt32(cdr[0]);
  bs = Convert.ToInt32(cdr[1]);
  pid = Convert.ToInt32(cdr[2]);
  cid = Convert.ToInt32(cdr[3]);

  SpectrumItem SpectrumItem = new SpectrumItem(st, pid, bs, tresh, dwl, corl, sp,cid);

  SpectList.Add(SpectrumItem);
}