Application-defined or object-defined error Or Run Time Error 1004

Question

0.00/5 (No votes)

See more:

```vb
Sub LoopThroughDirectory()
Dim MyFile As String
Dim erow
MyFile = Dir("C:\Users\SJPM\Desktop\Sal\")
Do While Len(MyFile) > 0
If MyFile = "zmaster.xlsm" Then
Exit Sub
End If
Workbooks.Open (MyFile)
Worksheets("Final Salary").Range("B22:E32").Copy
ActiveWorkbook.Save
ActiveWorkbook.Close
erow = ActiveWorksheets.Cells(Rows.Count, 1).End(xlUp).Offset(1, 0).Row
ActiveWorksheets.Paste Destination:=Worksheets("Sheet1").Range(Cells(erow, 1), Cells(erow, 4))

MyFile = Dir

Loop
End Sub
```

Posted 5-Apr-15 23:27pm

Member 10885804

Updated 5-Apr-15 23:50pm

Richard MacCutchan

v2

Add a Solution

Comments

Richard MacCutchan 6-Apr-15 5:49am

What is your question?

Member 10885804 6-Apr-15 5:51am

I Found run time error no 1004 when I compiling this code pl. help me

Richard MacCutchan 6-Apr-15 5:54am

Where? What does runtime error 1004 mean?

Member 10885804 6-Apr-15 5:57am

The full form of this error is this "Application-defined or object-defined error"
I do not know what is this I am running this code in excel vba platform

Richard MacCutchan 6-Apr-15 6:01am

I suggest you use the VBA debugger to step through the code to see where the error occurs. At a guess it could be something to do with trying to reference worksheet data after closing the workbook.

Member 10885804 6-Apr-15 6:04am

pl try by your self and help us I think at this line i am facing this error
erow = ActiveWorksheets.Cells(Rows.Count, 1).End(xlUp).Offset(1, 0).Row
ActiveWorksheets.Paste Destination:=Worksheets("Sheet1").Range(Cells(erow, 1), Cells(erow, 4))

Richard MacCutchan 6-Apr-15 6:11am

Yes, because as I suggested, you have closed the Workbook at that point, so there are no Worksheets available.

Member 10885804 6-Apr-15 6:21am

But at that point i have two workbooks

Richard MacCutchan 6-Apr-15 6:24am

Then you need to use your debugger to see exactly where the failure occurs. We cannot guess what is happening or see your screen.

Member 10885804 6-Apr-15 6:28am

Ok Thanks

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Answer 1 · 2015-04-06T09:47:00

The error occurs in this line:

VB

Workbooks.Open (MyFile)

because MyFile contains only file name without its path!

Try this:

VB

Sub LoopThroughDirectory()
Dim sFile As String, sPath As String, eRow as Integer
Dim srcWbk As Workbook, dstWbk as Workbook
Dim srcWsh As Worksheet, dstWsh as Worksheet 

Set dstWbk = ThisWorkbook
Set dstWsh = dstWbk.Worksheets("Sheet1")

sPath = "C:\Users\SJPM\Desktop\Sal\"
sFile = Dir(sPath)
Do While sFile<>""
    If MyFile = "zmaster.xlsm" Then
        Exit Do
    End If
    Set srcWbk = Application.Workbooks.Open(sPath & MyFile)
    Set srcWsh = Worksheets("Final Salary")
    eRow = dstwsh.Cells(Rows.Count, 1).End(xlUp).Offset(1, 0).Row
    srcWsh.Range("B22:E32").Copy dstWsh.Range(Cells(erow, 1), Cells(erow, 4))
    srcWbk.Close SaveChanges:=False
    MyFile = Dir()
Loop

'close destination workbook
dstWbk.Close SaveChanges:=True

End Sub

Note: you have to change above code to your needs!