Click here to Skip to main content
12,627,064 members (35,861 online)
Click here to Skip to main content
Add your own
alternative version

Stats

12.5K views
83 downloads
9 bookmarked
Posted

Another way for RETRY logic without using GOTO keyword

, 28 Apr 2014 CPOL
Rate this:
Please Sign up or sign in to vote.
Alternative way for implementing Abort/Retry/Ignore logic

Introduction

The above dialogue should be a quite common error prompt in our daily operation.

If the operation behind is just a simple action like copy one file, to implement the retry logic will be rather simple as well.

But this article will discuss the retry logic within sequential actions. E.g. Copy 10 files, the 5th file copy failed and a message box shown, now user should decide ‘Abort’, ‘Retry’ or ‘Ignore’. And based on user’s response, we now discuss how to implement the ‘Abort’, ‘Retry’ and ‘Ignore’ logic.

Background

Recently just saw such a file copy error dialogue with retry button during some software installation. Suddenly start to think how this should be implemented in a good way. As we all known, a common and a quick way to do retry is via ‘GOTO’ keyword, but this may mess up your logic and your codes. So I’m trying to avoid using ‘GOTO’ but via the recursion approach.

Implement the Logic

Let me show my demo codes first which implement the ‘Abort’, ‘Retry’ and ‘Ignore’ logic:

/// <summary>
/// This is the main function to do the work with retry logic
/// </summary>
/// <param name="jobName">Indicates current job name for displaying in message box</param>
/// <param name="retryCount">Indicates how many retried has been executed</param>
/// <returns>
/// -1: Abort is selected by user in message box
///  0: Ignore is selected by user in message box or there is no error when doing current job
/// </returns>
private int StartWorkProcess(string jobName, int retryCount)
{
    try
    {
        //do something here
        Console.WriteLine("doing job " + jobName + "...");

        //demo an exception when the job name's length equals to 3, 6 and 9
        if (Math.IEEERemainder(jobName.Length, 3)==0)
        {
            throw new Exception();
        }

    }
    catch
    {
        switch (MessageBox.Show("Failed doing job "  + jobName, string.Empty, MessageBoxButtons.AbortRetryIgnore, MessageBoxIcon.Error))
        {
            case System.Windows.Forms.DialogResult.Abort:
                return -1;  //Abort all
                break;
            case System.Windows.Forms.DialogResult.Retry:
                if (retryCount > 10)    //Limite the retry times
                {
                    switch (MessageBox.Show("Too many retries! Yes to abort the whole job, No to ignore current task.", string.Empty, MessageBoxButtons.YesNo, MessageBoxIcon.Warning))
                    {
                        case System.Windows.Forms.DialogResult.Yes:
                            return -1;  //Abort all
                            break;
                        case System.Windows.Forms.DialogResult.No:
                            //do nothing more
                            return 0;
                            break;
                    }
                }
                else
                {
                    return StartWorkProcess(jobName, retryCount + 1);
                }
                break;
            case System.Windows.Forms.DialogResult.Ignore:
                //do nothing more
                break;
        }
    }
    return 0;
}

This is the main method to do the work with ‘Abort’, ‘Retry’ and ‘Ignore’ logic.

Here is some key points:

  1. Using a try…catch block to catch any exceptions. Of course, you may extend this to multiple catches to specify certain exceptions.
  2. When there is an exception, and user chooses to retry, this method increase retryCount and calls itself again to redo the same logic for retrying.
  3. A return value is necessary to indicate the status and for the caller function to do its own work.
  4. The number of retrying times is also necessary to be traced and force abort or ignore current task when the number of retrying times exceed the threshold value. This may avoid potential out of memory and stack overflow issue.

And here is the caller function, which will use the return value of the work method:

/// <summary>
/// On OK button click, it will call the work function to do the job.
/// </summary>
/// <param name="sender"></param>
/// <param name="e"></param>
private void btnOK_Click(object sender, EventArgs e)
{
    string job = string.Empty;
    //Simulate 9 jobs with job name 1, 12, 123, 1234 and etc.
    for (int i = 1; i < 10; i++)
    {
        job = job + i.ToString();
        if (StartWorkProcess(job, 0) == -1)
        {
            break;
        }
    }
}

When running the codes, you may monitor result via the program outputs in Visual Studio Output window. Here shows a sample output:

doing job 1...
doing job 12...
doing job 123...
A first chance exception of type 'System.Exception' occurred in RetryIgnoreInRecursion.exe
doing job 123...
doing job 123...
A first chance exception of type 'System.Exception' occurred in RetryIgnoreInRecursion.exe
A first chance exception of type 'System.Exception' occurred in RetryIgnoreInRecursion.exe
doing job 1234...
doing job 12345...
doing job 123456...
doing job 1234567...
doing job 12345678...
doing job 123456789...

Now Do Something Better

Now you should have a basic idea about what I’m talking about and how the logic is implemented in codes. But let us do something better, using the template method pattern to make the codes reusable.

An abstract class is created and basic retry/ignore/abort logic is implemented, while the actual working logic is not implemented but leave it to subclass as an abstract method.

abstract class RetryIgnoreHandlerBase
{
    /// <summary>
    /// Abstract method for subclass to implement actual working logic
    /// </summary>
    protected abstract void DoActualJob(string jobName);

    /// <summary>
    /// This is the main function to do the work with retry logic
    /// </summary>
    /// <param name="jobName">Indicates current job name for displaying in message box</param>
    /// <param name="retryCount">Indicates how many retried has been executed</param>
    /// <returns>
    /// -1: Abort is selected by user in message box
    ///  0: Ignore is selected by user in message box or there is no error when doing current job
    /// </returns>
    public int StartWorkProcess(string jobName, int retryCount)
    {
        try
        {
            DoActualJob(jobName);
        }
        catch
        {
            switch (MessageBox.Show("Failed doing job " + jobName, string.Empty, MessageBoxButtons.AbortRetryIgnore, MessageBoxIcon.Error))
            {
                case System.Windows.Forms.DialogResult.Abort:
                    return -1;  //Abort all
                    break;
                case System.Windows.Forms.DialogResult.Retry:
                    if (retryCount > 10)    //Limite the retry times
                    {
                        switch (MessageBox.Show("Too many retries! Yes to abort the whole job, No to ignore current task.", string.Empty, MessageBoxButtons.YesNo, MessageBoxIcon.Warning))
                        {
                            case System.Windows.Forms.DialogResult.Yes:
                                return -1;  //Abort all
                                break;
                            case System.Windows.Forms.DialogResult.No:
                                //do nothing more
                                return 0;
                                break;
                        }
                    }
                    else
                    {
                        return StartWorkProcess(jobName, retryCount + 1);
                    }
                    break;
                case System.Windows.Forms.DialogResult.Ignore:
                    //do nothing more
                    break;
            }
        }
        return 0;
    }
}

The subclass inherit the above abstract class and implement the actual working logic instead:

class DemoRetry: RetryIgnoreHandlerBase
{
    protected override void DoActualJob(string jobName)
    {
        //do something here
        Console.WriteLine("doing job " + jobName + "...");

        //demo an exception when the job name's length equals to 3, 6 and 9
        if (Math.IEEERemainder(jobName.Length, 3) == 0)
        {
            throw new Exception();
        }
    }
}

Then the relevant change to the caller function:

private void btnOK_Click(object sender, EventArgs e)
{
    string job = string.Empty;
    DemoRetry demo = new DemoRetry();

    //Simulate 9 jobs with job name 1, 12, 123, 1234 and etc.
    for (int i = 1; i < 10; i++)
    {
        job = job + i.ToString();
        if (demo.StartWorkProcess(job, 0) == -1)
        {
            break;
        }
    }
}

Your Solution is Welcome

Is there any other solution to implement the abort/retry/ignore logic? Please feel free to leave comments and share with all.

History

April, 2014, Version 1.

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Share

About the Author

TonyTonyQ
Architect
China China
No Biography provided

You may also be interested in...

Pro
Pro

Comments and Discussions

 
QuestionThis is the right way to do it. Pin
Joe Gakenheimer19-Aug-14 8:05
memberJoe Gakenheimer19-Aug-14 8:05 
GeneralVote of 1 would be too generous Pin
Steve Solomon28-Apr-14 23:08
memberSteve Solomon28-Apr-14 23:08 
GeneralMy vote of 1 Pin
johannesnestler28-Apr-14 11:08
memberjohannesnestler28-Apr-14 11:08 
Question不错 Pin
Member 1020865924-Apr-14 15:19
memberMember 1020865924-Apr-14 15:19 
AnswerRe: 不错 Pin
Nelek28-Apr-14 6:00
memberNelek28-Apr-14 6:00 
QuestionHow about this code? Pin
FatCatProgrammer24-Apr-14 7:59
memberFatCatProgrammer24-Apr-14 7:59 
AnswerRe: How about this code? Pin
John Brett25-Apr-14 6:30
memberJohn Brett25-Apr-14 6:30 
GeneralRe: How about this code? Pin
FatCatProgrammer25-Apr-14 7:58
memberFatCatProgrammer25-Apr-14 7:58 
BugMissing picture at top Pin
James Jensen24-Apr-14 5:01
professionalJames Jensen24-Apr-14 5:01 
GeneralRe: Missing picture at top Pin
TonyTonyQ24-Apr-14 6:08
professionalTonyTonyQ24-Apr-14 6:08 
GeneralRe: Missing picture at top Pin
Ravi Bhavnani24-Apr-14 6:52
professionalRavi Bhavnani24-Apr-14 6:52 
SuggestionConsider use of Actions Pin
Henrik Jonsson24-Apr-14 4:07
memberHenrik Jonsson24-Apr-14 4:07 
QuestionWhy not just use GOTO ?? Pin
TactiveR224-Apr-14 3:22
memberTactiveR224-Apr-14 3:22 
AnswerRe: Why not just use GOTO ?? Pin
John Brett24-Apr-14 4:33
memberJohn Brett24-Apr-14 4:33 
AnswerRe: Why not just use GOTO ?? Pin
PIEBALDconsult24-Apr-14 4:56
memberPIEBALDconsult24-Apr-14 4:56 
AnswerRe: Why not just use GOTO ?? Pin
CHill6024-Apr-14 6:40
protectorCHill6024-Apr-14 6:40 
AnswerRe: Why not just use GOTO ?? Pin
Victoria TO25-Apr-14 1:50
memberVictoria TO25-Apr-14 1:50 
AnswerRe: Why not just use GOTO ?? Pin
rxantos1-May-14 17:00
memberrxantos1-May-14 17:00 
QuestionHow about a do ... while (true)? Pin
Vasudevan Deepak Kumar24-Apr-14 2:44
memberVasudevan Deepak Kumar24-Apr-14 2:44 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.

| Advertise | Privacy | Terms of Use | Mobile
Web02 | 2.8.161205.3 | Last Updated 28 Apr 2014
Article Copyright 2014 by TonyTonyQ
Everything else Copyright © CodeProject, 1999-2016
Layout: fixed | fluid