There is already an open DataReader associated with this Command which must be closed first.

Question

0.00/5 (No votes)

See more:

VB

Private Sub tool_save_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles tool_save.Click
        'On Error Resume Next

        Dim cmd As New SqlCommand
        cmd.Connection = _OpenConnect()
        cmd.CommandType = CommandType.Text
        cmd.CommandText = "INSERT INTO Customer_Info (Cust_Name,Address,City,Phone,Cust_Invoice) Values (@Cust_Name,@Address,@City,@Phone,@Cust_Invoice)"
        With cmd.Parameters
            .AddWithValue("@Cust_Name", txt_custName.Text)
            .AddWithValue("@Address", txt_address.Text)
            .AddWithValue("@City", txt_city.Text)
            .AddWithValue("@Phone", txt_phone.Text)
            .AddWithValue("@Cust_Invoice", txt_cust_Invoice.Text)
        End With

        cmd.ExecuteNonQuery()


        txt_custName.Focus()
        Message("Inserted Successfully")
        ClearAll(Me)
        Cust_Info.AttachData()
        main.GetBasicInfo()
    End Sub

====================================================
Same Problem
This type error are given

There is already an open DataReader associated with this Command which must be closed first.

Posted 10-Jun-12 21:28pm

gauravrank

Updated 10-Jun-12 21:39pm

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mehdi Gholam · Answer 1 · 2012-06-10T21:36:00

Solution 1

Like the error says there is an open Datareader on your connection. Check your code before this routine and close the DataReader first then call this sub.

Posted 10-Jun-12 21:36pm

Mehdi Gholam

Comments

gauravrank 11-Jun-12 3:41am

Public Function _OpenConnect() As SqlConnection
Try
If _cn.ConnectionString = "" Then
_cn.ConnectionString = _GlobalConString
End If
If _cn.State = ConnectionState.Closed Then
_cn.Open()
End If
Catch ex As Exception
MsgBox(ex.Message)
End Try
Return _cn
End Function

This Function is my connection function

Mehdi Gholam 11-Jun-12 3:45am

A part of your code is using this connection with a datareader. Search for "datareader" in your project and work from there to see where you are not closing the datareader.

gauravrank 11-Jun-12 3:47am

i alredy check that all datareader is closed

Mehdi Gholam 11-Jun-12 3:52am

You will have to trust the computer when it says it is not closed :)

gauravrank 11-Jun-12 3:56am

pls when you free then i share my pc in teamviewer pls chek

Mehdi Gholam 11-Jun-12 4:02am

Sorry that is not possible.

gauravrank 11-Jun-12 4:10am

ok no problem and thank for your help

Bernhard Hiller · Answer 2 · 2012-06-10T23:51:00

Solution 2

Look at that line:
cmd.Connection = _OpenConnect()
and then to a line in that function
_cn.ConnectionString
You use always the same SqlConnection object!
That's the reason for your problems. Create a new SqlConnection object when required.

Posted 10-Jun-12 23:51pm

Bernhard Hiller