C# Downloade Download Progress/Complete

Question

2.00/5 (1 vote)

See more:

I added a progressbar and i wanted the program to launh the downloaded file but when the download is complete nothing happens at all!

C#

public void button4_Click(object sender, EventArgs e)
        {
            using (System.IO.FileStream fs = System.IO.File.Create("\\aos075install.msi")) ;

            progressBar.Visible = true;

            WebClient webClient = new WebClient();


            webClient.DownloadFile("http://www.spadille.net/aos075install.msi", @"C:\aos075install.msi");

            webClient.DownloadProgressChanged += new DownloadProgressChangedEventHandler(ProgressChanged);


            webClient.DownloadFileCompleted += new AsyncCompletedEventHandler(Completed);


        }
             void ProgressChanged(object sender, DownloadProgressChangedEventArgs e)
                    {
                        progressBar.Value = e.ProgressPercentage;
                    }



              void Completed(object sender, AsyncCompletedEventArgs e)
                    {
                        MessageBox.Show("Download Successfull!");
                        progressBar.Visible = false;
                        System.Diagnostics.Process.Start("\\aos075install.msi");
                    }

              private void button5_Click(object sender, EventArgs e)
                    {
                        System.Diagnostics.Process.Start("\\Ace of Spades\\readme.txt");
                    }

thanks for help!

Posted 5-Feb-13 7:50am

FrontFreak

Add a Solution

Comments

Sergey Alexandrovich Kryukov 5-Feb-13 14:14pm

What, you don't see 100% in ProgressChanges? How do you know that it's complete?
Did you run it under debugger to see if Completed is called, ever? Does it happen to all URLs you try, or this is only one case?
—SA

Jibesh 5-Feb-13 14:17pm

"when the download is complete nothing happens at all" is really nothing to us. you should tell what is the real problem you are facing. Please keep in mind that we cannot see your monitor,HDD or complete source code so you must provide enough details to solve your problem.

If you are expecting to start the MSI installed once the download is complete, check the path where you copied the file and running using Process start, they are different

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard C Bishop · Answer 1 · 2013-02-05T08:15:00

Change your ProgressChanged() method content to this:

C#

double bytesIn = double.Parse(e.BytesReceived.ToString());
double totalBytes = double.Parse(e.TotalBytesToReceive.ToString());
double percentage = bytesIn / totalBytes * 100;
progressBar.Value = int.Parse(Math.Truncate(percentage).ToString());

Sergey Alexandrovich Kryukov · Answer 2 · 2013-02-05T08:22:00

I did not experience such problems, but I use different API which allows for more control and is more universal, System.Net.HttpWebRequest:
http://msdn.microsoft.com/en-us/library/system.net.httpwebrequest.aspx[^].

For a complete working sample, all in a single file, please see my past answer: how to download a file from internet[^].

My utility, HttpDownloader, allows to continue downloading of partially downloaded resource. This is possible, in particular, because HTTP response gives you the expected total size in the very beginning. This way, you can detect progress and indicate 100% progress when the size of the downloaded data becomes equal to the expected size.

Just the alternative you could consider, a very simple one but more universal.

—SA

C# Downloade Download Progress/Complete

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0