Nullreference drawingplayers with C# for ESP

Question

0.00/5 (No votes)

See more:

Hi, happy new year to all :) and now to problem can somebody tell me first what is meaning of nullreference but of easy way.
Second why is nullreference meaking me problem when am in game and my screen starts bliking black, my esp losse color etc..

CODE FROM ESP:

C#

using System;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using System.IO;
using UnityEngine;
using EFT;
using EFT.Interactive;

namespace Absolutly
{
    public class Abso : MonoBehaviour
    {

        public Abso() { }
        #region variable
        private GameObject GameObjectHolder;

        private IEnumerable<Player> _playerInfo;
        private IEnumerable<ExfiltrationPoint> _extractPoints;
        private IEnumerable<LootItem> _item;

        private float _playNextUpdateTime;
        private float _evaNextUpdateTime;
        protected float _infoUpdateInterval = 15f;


        private bool _isInfoMenuActive = true;
        private bool _showItems;
        private bool _pInfor;
        private bool _showExtractInfo;

        private float _viewdistance = 300f;
        private float _lootItemDistance = 50f;
        private float _espUpdateInterval = 50f;
        private float _itemsNextUpdateTime;
        private Player _localPlayer;
        private Vector3 camPos;
        #endregion

        #region import

        [DllImport("user32.dll")]
        static extern bool GetCursorPos(out POINT lpPoint);

        [DllImport("user32.dll")]
        static extern void mouse_event(int dwFlags, int dx, int dy, int dwData, int dwExtraInfo);

        private const int MOUSEEVENTF_MOVE = 0x0001;
        public static void Move(int xDelta, int yDelta)
        {
            mouse_event(MOUSEEVENTF_MOVE, xDelta, yDelta, 0, 0);
        }
        public struct POINT
        {
            public int X;
            public int Y;
        }
        #endregion

        private void Awake()
        {
            Debug.logger.logEnabled = false;
        }

        private void Start()
        {
            Clear();
        }
        private void Clear()
        {
            _playerInfo = null;
            _extractPoints = null;
            _item = null;
            _itemsNextUpdateTime = 0;
            _localPlayer = null;
        }

        public void Load()
        {
            GameObjectHolder = new GameObject();
            GameObjectHolder.AddComponent<Abso>();
            DontDestroyOnLoad(GameObjectHolder);
        }


        public void Unload()
        {
            Clear();
            Destroy(GameObjectHolder);
            Destroy(GameObjectHolder.GetComponent<Abso>());
            Destroy(this);
            DestroyObject(this);
        }

        private void OnDisable()
        {
            Clear();
        }
        private void OnDestroy()
        {
            Clear();
        }


        private void Update()
        {
            if (Input.GetKeyDown(KeyCode.F1))
            {
                Unload();
            }
            if (Input.GetKeyDown(KeyCode.F11))
            {
                _isInfoMenuActive = !_isInfoMenuActive;
            }

        }

        private void OnGUI()
        {
            if (_isInfoMenuActive)
            {
                GUIOverlay();
            }
            if ((_pInfor && Time.time >= _playNextUpdateTime) || ( Time.time >= _playNextUpdateTime))
            {
                _playerInfo = FindObjectsOfType<Player>();
                _playNextUpdateTime = Time.time + _infoUpdateInterval;
            }
            if (_pInfor)
            {
                DrawPlayers();
            }
            if (_showExtractInfo && Time.time >= _evaNextUpdateTime)
            {
                _extractPoints = FindObjectsOfType<ExfiltrationPoint>();
                _evaNextUpdateTime = Time.time + _infoUpdateInterval;
            }

            if (_showExtractInfo)
            {
                DrawExtractInfo();
            }
            if (_showItems)
            {
                if (Time.time >= _itemsNextUpdateTime)
                {
                    _item = FindObjectsOfType<LootItem>();
                    _itemsNextUpdateTime = Time.time + _espUpdateInterval;
                }
                ShowItemESP();
            }
        }
        private void GetLocalPlayer()
        {
            foreach (Player player in FindObjectsOfType<Player>())
            {
                if (player == null) continue;

                if (EPointOfView.FirstPerson == player.PointOfView && player != null)
                {
                    _localPlayer = player;
                }
            }
        }


        private void DrawExtractInfo()
        {
            try
            {
                foreach (var point in _extractPoints)
                {
                    float distanceToObject = Vector3.Distance(Camera.main.transform.position, point.transform.position);
                    var exfilContainerBoundingVector = new Vector3(
                        Camera.main.WorldToScreenPoint(point.transform.position).x,
                        Camera.main.WorldToScreenPoint(point.transform.position).y,
                        Camera.main.WorldToScreenPoint(point.transform.position).z);

                    if (exfilContainerBoundingVector.z > 0.01)
                    {
                        Color guiBackup = GUI.color;
                        GUI.color = Color.green;
                        int distance = (int)distanceToObject;
                        String exfilName = point.name;
                        string boxText = $"{exfilName} - {distance} M";

                        GUI.Label(new Rect(exfilContainerBoundingVector.x - 50f, (float)Screen.height - exfilContainerBoundingVector.y, 100f, 50f), boxText);
                        GUI.color = guiBackup;
                    }
                }
            }
            catch (NullReferenceException ex)
            {
                File.AppendAllText
                (
                   @"C:\EFT\EXITS.txt",
                   $"{ex.Message}\r\n{ex.StackTrace}\r\n"
                );
            }
        }

        private void ShowItemESP()
        {
            foreach (var Item in _item)
            {
                if (Item == null)
                    continue;

                float distance = Vector3.Distance(Camera.main.transform.position, Item.transform.position);
                Vector3 ItemBoundingVector = new Vector3(Camera.main.WorldToScreenPoint(Item.transform.position).x, Camera.main.WorldToScreenPoint(Item.transform.position).y, Camera.main.WorldToScreenPoint(Item.transform.position).z);
                if (ItemBoundingVector.z > 0.01 && Item != null && (Item.name.Contains("key") || Item.name.Contains("tetriz") || Item.name.Contains("prokill") || Item.name.Contains("ssd") || Item.name.Contains("virtexprocessor") || Item.name.Contains("video_card") || Item.name.Contains("transilluminator")) && distance <= _lootItemDistance)
                {
                    name = Item.name;

                    string text = string.Format($"{Item.name} - [{distance}]M");
                    Color guiBackup = GUI.color;
                    GUI.color = Color.cyan;
                    GUI.Label(new Rect(ItemBoundingVector.x - 50f, (float)Screen.height - ItemBoundingVector.y, 100f, 50f), text);
                    GUI.color = guiBackup;
                }
            }
        }


        private void DrawPlayers()
        {
            foreach (var player in _playerInfo)
                {

                try
                {
                    if (player == null)
                    {
                        break;
                    }

                    if (player.Profile.Info.Nickname == string.Empty)
                    {
                        continue;
                    }

                    if (!player.IsVisible) continue;

                    Vector3 playerPos = player.Transform.position;
                    float distanceToObject = Vector3.Distance(camPos, player.Transform.position);
                    Vector3 playerBoundingVector = Camera.main.WorldToScreenPoint(playerPos);
                    if (distanceToObject <= _viewdistance && playerBoundingVector.z > 0.01)
                    {
                        Vector3 playerHeadVector = Camera.main.WorldToScreenPoint(player.PlayerBones.Head.position);
                        Gizmos.DrawCube(playerPos, new Vector3(1, 1, 2));
                        float boxVectorX = playerBoundingVector.x;
                        float boxVectorY = playerHeadVector.y + 10f;
                        float boxHeight = Math.Abs(playerHeadVector.y - playerBoundingVector.y) + 10f;
                        float boxWidth = boxHeight * 0.65f;
                        var IsAI = player.Profile.Info.RegistrationDate <= 0;
                        var playerColor = player.HealthController.IsAlive ? GetPlayerColor(player.Side) : Color.gray;
                        Utility.DrawBox(boxVectorX - boxWidth / 2f, Screen.height - boxVectorY, boxWidth, boxHeight, playerColor);
                        Utility.DrawLine(new Vector2(playerHeadVector.x - 2f, Screen.height - playerHeadVector.y), new Vector2(playerHeadVector.x + 2f, Screen.height - playerHeadVector.y), playerColor);
                        Utility.DrawLine(new Vector2(playerHeadVector.x, Screen.height - playerHeadVector.y - 2f), new Vector2(playerHeadVector.x, Screen.height - playerHeadVector.y + 2f), playerColor);
                        var playerName = IsAI ? "[BOT]" : player.Profile.Info.Nickname;
                        string playerText = player.HealthController.IsAlive ? playerName : (playerName + " [MRTAV]");
                        string playerTextDraw = string.Format("{0} [{1}]", playerText, (int)distanceToObject);
                        var playerTextVector = GUI.skin.GetStyle(playerText).CalcSize(new GUIContent(playerText));
                        GUI.Label(new Rect(playerBoundingVector.x - playerTextVector.x / 2f, Screen.height - boxVectorY - 20f, 300f, 50f), playerTextDraw);
                    }
                }
                catch (NullReferenceException ex)
                {
                    File.AppendAllText
                    (
                       @"C:\EFT\DrawPlay.txt",
                       $"{ex.Message}\r\n{ex.StackTrace}\r\n"
                    );
                }
            }

        }


        private Color GetPlayerColor(EPlayerSide side)
        {
            switch (side)
            {
                case EPlayerSide.Bear:
                    return Color.red;
                case EPlayerSide.Usec:
                    return Color.blue;
                case EPlayerSide.Savage:
                    return Color.yellow;
                default:
                    return Color.yellow;
                    /*
                    case EPlayerSide.Bear:
                        return ColorUtility.TryParseHtmlString(_bearColor);
                    case EPlayerSide.Usec:
                        return ColorUtility.TryParseHtmlString(_usecColor);
                    case EPlayerSide.Savage:
                        return ColorUtility.TryParseHtmlString(_scavColor);
                    default:
                        return Color.white;
                        */
            }
        }

        private void GUIOverlay()
        {
            GUI.color = Color.gray;
            GUI.Box(new Rect(100f, 100f, 400f, 500f), "");
            GUI.color = Color.white;
            GUI.Label(new Rect(180f, 110f, 150f, 20f), "CITESKI MENI");
            _pInfor = GUI.Toggle(new Rect(110f, 140f, 120f, 20f), _pInfor, "IGRACI ESP"); // Display player
            _showExtractInfo = GUI.Toggle(new Rect(110f, 160f, 120f, 20f), _showExtractInfo, "EXSTRAKTI"); //Display  extraction

            _showItems = GUI.Toggle(new Rect(110f, 280f, 120f, 20f), _showItems, "LOOT STVARI"); //Show items on map
            if (_showItems)
            {
                GUI.Label(new Rect(110f, 320f, 150f, 20f), "LOOT DISTANCA");
                _lootItemDistance = GUI.HorizontalSlider(new Rect(210f, 320f, 120f, 20f), _lootItemDistance, 0.0F, 1500.0F);
            }
        }

        private double GetDistance(double x1, double y1, double x2, double y2)
        {
            return Math.Sqrt(Math.Pow(x2 - x1, 2.0) + Math.Pow(y2 - y1, 2.0));
        }

        private void Circle(int X, int Y, int radius)
        {
            float boxXOffset = X;
            float boxYOffset = Y;
            float boxHeight = radius;
            float boxwidth = radius;
            Vlcrpc.DrawBox(boxXOffset - (radius / 2), boxYOffset - (radius / 2), radius, radius, Color.yellow);
            Vlcrpc.DrawLine(new Vector2(960, 1080), new Vector2(960, 0), Color.white);
            Vlcrpc.DrawLine(new Vector2(0, 540), new Vector2(1920, 540), Color.white);
        }

    }

}

What I have tried:

Replace all code
Update GUI
GUI backup color added
null reference added
nothing worked at all

Posted 5-Jan-20 14:19pm

MRHals Gospodin

Updated 5-Jan-20 22:44pm

v2

Add a Solution

3 solutions

Solution 1

Any object can be null. Null means it doesn't exist.

AnyClass x = null;

now x.anyProperty will throw an error as x is NOT 'AnyClass' yet, it is null, a placeholder to contain an AnyClass when you make one

Posted 5-Jan-20 14:22pm

Christian Graus

Comments

MRHals Gospodin 5-Jan-20 20:32pm

But how can i implement that now on my way to now make it normaly working?

MRHals Gospodin 5-Jan-20 20:33pm

How can am cache this all abov? will that fix my problem?

Christian Graus 5-Jan-20 20:55pm

Your code is not helpful. Player is obviously not null. I have no clue what is, as you don't say what line has the error

MRHals Gospodin 5-Jan-20 21:08pm

I have just one error whats reapeate over and over:

System.NullReferenceException: Object reference not set to an instance of an object
at Absolutly.Abso.DrawPlayers () [0x00029] in <9854d861ae0d247c498e2782f3e1d916>:0

Christian Graus 5-Jan-20 22:50pm

See, a line number would tell me (or you if you look) what is null. Do you know how to use a debugger? Put a try catch around all this and when it catches, step through it again and see what is null

MRHals Gospodin 6-Jan-20 4:25am

when i use debuger its not giving error-s thats real pain. have you any contact myb?

MRHals Gospodin 6-Jan-20 4:32am

Am updated official post abov, for more info if you myb can spot my error will be awsom. this full working code.

Solution 2

Using the debugger would be the fastest way for you to spot the issue. We cannot debug for you. Do you need help on how to conduct a debug session?

You could also change the way you are logging exceptions; try to change the catch block to

C#

catch (NullReferenceException ex)
{
   File.AppendAllText
   (
      @"C:\exeptionseft\DrawPlay.txt",
      $"{ex.Message}\r\n{ex.StackTrace}\r\n"
   );
}

and you will start getting better informations about what is going on and where it is happening.

Posted 5-Jan-20 21:24pm

phil.o

Comments

MRHals Gospodin 6-Jan-20 4:25am

I will try thank you

MRHals Gospodin 6-Jan-20 4:32am

Am updated official post abov, for more info if you myb can spot my error will be awsom. this full working code.

phil.o 6-Jan-20 5:15am

Sorry, but my answer is the same: debug your code to find where and why you get the exception. I cannot do that for you. Please also see answer nb. 3 by Richard MacCutchan.

MRHals Gospodin 6-Jan-20 6:27am

debug didnt show me any errors.

phil.o 6-Jan-20 6:30am

But you still get an exception, right? Debugging does not show you any error, it just allows you to spot eventual issues with your code.
Again, do you need help on how to conduct a debug session?

MRHals Gospodin 6-Jan-20 6:48am

Thank you first for all support for this project, yes i need support about debuging and how to find out real problem. Becauss am using Debug function and its not giving any errors and am not sure its me whats meaking this wrong or its nothing to show in debug.
If you have time to help me sure :)

PIC: https://i.imgur.com/JQH8Ibm.png

phil.o 6-Jan-20 6:58am

Debugging is a skill which you need to practice if you are serious as a developper. It allows you to investigate your code by executing it line-by-line, and watching the values of your variables.
Here are a couple of links to get you started:
Introduction to debugging[^]
Tutorial: Learn to debug C# code using Visual Studio[^]
There are other sources, though; I'm pretty sure you even can find some in your native language, if that makes it easier. You really should take the time to get familiar with debugging, as it is an essential skill.

MRHals Gospodin 6-Jan-20 7:03am

Thank you will look right in to it :)

MRHals Gospodin 6-Jan-20 17:11pm

I try debug but dont give me any errors, am loosing hoppe.

phil.o 6-Jan-20 17:24pm

Not knowing how you actually tried to debug, I'm afraid I can't help further. Again, you are the only one who can do it. Debugging does not "give errors" or flag them automatically; it is a tool for you to investigate what is going on.
Where did you put the breakpoint? Which line does throw the exception? Which variable is null? How/where do you intialize this variable? All these are questions which you are the only one being able to answer to at this time.

Christian Graus 6-Jan-20 17:14pm

If there's no errors, your code works!!!!!

phil.o 6-Jan-20 17:26pm

We get that qute often :) A lot of beginners tend to understand the debugger as a magic tool which will solve all issues automatically, not as an investigation tool.

Christian Graus 6-Jan-20 17:33pm

It's an adventure :)

MRHals Gospodin 6-Jan-20 18:11pm

Its not problem in debug becauss i have internal cheat .dll i cant debug stuff like exsecutable programs. I need to compile it and try if it will drop same errors.

here is last idea what i haved in my mide
if (player == null)
{
File.WriteAllText("greske.txt", "player object is null.");
File.WriteAllText("greske.txt", _ply.ToString());
foreach (var p in _ply)
{
File.WriteAllText("greske.txt", $"Player {p.Profile?.Info?.Nickname ?? "'Unknown' is null"}: \n{p.ToString()}");
}
File.WriteAllText("greske.txt", _ply.ToString());
return;
}
but not working to finde out more and i found out PLAYer null is error but fix dont now

Christian Graus 6-Jan-20 18:34pm

Honestly, if you get an exception it will tell you in the stack trace what line has the error. IF you can't debug your code, fix it so you can

If player is null, the code to load it is not working

MRHals Gospodin 6-Jan-20 18:38pm

But how to debug .dll? file

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2020-01-05T22:44:00

Solution 3

This is the same issue as https://www.codeproject.com/Questions/5255717/Csharp-ESP-drawing-error[^], and you already received a suggestion. The problem is that by capturing the exception you are losing information that the system would produce automatically. Remove the try catch and you will get details of where the exception occurs. From that you should be able to fix it without difficulty.

Posted 5-Jan-20 22:44pm

Richard MacCutchan

Comments

MRHals Gospodin 6-Jan-20 6:25am

I try that option all ready but not help me alot with Topic and this with removing Catch noup its fine the code but the game make me problems again and am loosing hoppe to fix this and am wanna fix this becauss i invest many hours to create this. ESP

If you can tell me more details what can be wrong will help me alot

Richard MacCutchan 6-Jan-20 6:45am

As has been explained already, a null reference simply means that you are trying to use a reference that has not been initialised. Unfortunately, the only way to find them is by using the debugger to trace through the code and see exactly where the problem occurs. It may be that you forgot to initialise the reference, or you expect a return from some called method to return it. In almost every case it is simply because you forgot, or missed, something when initially writing your code. And, to be honest, there is not much we can do to help unless we can see an obvious mistake in the code that you show us. But more often than not the mistakes are not obvious. But don't be disheartened, it is a problem that we have all faced from time to time, and sometimes still do. It is just another part of the learning process that all developers go through.

MRHals Gospodin 6-Jan-20 6:47am

You have right i will keep looking in to code myb am blind so see someting and need to look better, thank you for all help.
Can you tell me how is Cache in c# works to cache drawedplayer and then to loop it again? simple code thank you again

PIC: https://i.imgur.com/JQH8Ibm.png

Richard MacCutchan 6-Jan-20 7:03am

I am not sure what you mean by "Cache", but see cache image c - Google Search[^], for some suggestions.

MRHals Gospodin 6-Jan-20 7:27am

I mean can i players what are drawed just Cache and loope it again?

Like player Box 1
save.
And if new players joins in to game
Take Box1 one and put on player 2
Without to need program to draw for each player boxes

Richard MacCutchan 6-Jan-20 8:04am

I think it may be possible, take a look at the Google link in my previous message for some suggestions.

MRHals Gospodin 6-Jan-20 17:10pm

Nahhh 10 hours later didnt fix the error yet...

Richard MacCutchan 6-Jan-20 17:18pm

No one said it was easy. But you wrote the code so you are the best person to understand where to look.

Christian Graus 6-Jan-20 17:15pm

Or set breakpoints and examine it, step through again......

MRHals Gospodin 6-Jan-20 18:11pm

error is player is null but idk how to fix

Richard MacCutchan 7-Jan-20 3:37am

Start from the point where the player reference is supposed to be set, and look to see why it is failing. As stated before this is not something that we can do for you, as it requires stepping through the code with the debugger.