How to sort a EDMX class list

Question

0.00/5 (No votes)

See more:

Hi,

I am trying to study MVC. I have an EDMX class which represents an Employee entity which has 5 properties ID,Name,Email,Address & IsActive.

I am trying to sort the employee list using linq. The sorting field is dynamically set based on which column is clicked in list page.

This is the code i have written

C#

public List<Employee> GetEmployees(bool includeInActive = false, string searchKey = "", string sortingField = "ID", string sortingDirection = "asc")
       {
           DB_Arjun objDB_ArjunEntities;
           try
           {
               objDB_ArjunEntities = new DB_Arjun();
               List<Employee> lstEmployee = new List<Employee>();

               if (string.IsNullOrWhiteSpace(searchKey))
               {
                   if (sortingDirection != "asc")
                   {
                       var tmpList = from employee in objDB_ArjunEntities.Employees.ToList()
                                     orderby sortingField descending
                                     select employee;

                       foreach (Employee emp in tmpList.ToList())
                       {
                           if (includeInActive)
                               lstEmployee.Add(emp);
                           else if (!includeInActive && emp.IsActive == true)
                               lstEmployee.Add(emp);
                       }
                   }
                   else
                   {
                       var tmpList = from employee in objDB_ArjunEntities.Employees.ToList()
                                     orderby sortingField
                                     select employee;

                       foreach (Employee emp in tmpList.ToList())
                       {
                           if (includeInActive)
                               lstEmployee.Add(emp);
                           else if (!includeInActive && emp.IsActive == true)
                               lstEmployee.Add(emp);
                       }
                   }
               }
               else
               {
                   var tmpList = from employee in objDB_ArjunEntities.Employees.ToList()
                                 where employee.Name == searchKey || employee.Address == searchKey || employee.Email == searchKey
                                 orderby sortingField
                                 select employee;

                   //var query =  from employee in objDB_ArjunEntities.Employees.ToList().Where(objDB_ArjunEntities.Employees. == searchKey || objDB_ArjunEntities.Employees. == searchKey || employee.Email == searchKey).OrderBy("Name asc");

                   foreach (Employee emp in objDB_ArjunEntities.Employees.ToList())
                   {
                       if (includeInActive && (emp.Name.Contains(searchKey) || emp.Address.Contains(searchKey) || emp.Email.Contains(searchKey)))
                           lstEmployee.Add(emp);
                       else if (!includeInActive && emp.IsActive == true && (emp.Name.Contains(searchKey) || emp.Address.Contains(searchKey)))
                           lstEmployee.Add(emp);
                   }
               }
               return lstEmployee;
           }
           catch (Exception ex)
           {
               throw ex;
           }
       }

But the problem is that the sorting is not working properly. The sorting address and sortdirection is correct but the sorting is not working..

Can anyone please help me

Posted 31-Mar-14 21:37pm

Arjun Menon U.K

Updated 31-Mar-14 21:38pm

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

gggustafson · Answer 1 · 2014-04-02T10:20:00

You do not have to perform an ascending or descending sort. Just perform an ascending sort and access the resulting list from one end or the other.

By adding .ToList ( ) to the end of your Linq statements, you do not need to add it later on. For example,

C#

temporary =
    ( from employee in objDB_ArjunEntities.
                           Employees.ToList ( )
      orderby sortingField
      select employee ).ToList ( );

In else if of your code:

C#

if (includeInActive)
    lstEmployee.Add(emp);
else if (!includeInActive && emp.IsActive == true)
    lstEmployee.Add(emp);

you do not have to test !includeInActive - we know it's false. Also, ALWAYS place braces around the if statement bodies; because emp.IsActive is a boolean, you only have to test its values. Revised code:

C#

if ( includeInActive )
    {
    lstEmployee.Add ( emp );
    }
else if ( emp.IsActive )
    {
    lstEmployee.Add ( emp );
    }

In the case where a search key is provided, the sort is always ascending. Shouldn't sort order follow the invoker's preference?

Following the statement

C#

var tmpList = from employee in objDB_ArjunEntities.
                                   Employees.ToList()
              where ( employee.Name == searchKey ||
                      employee.Address == searchKey || e
                      mployee.Email == searchKey )
              orderby sortingField
              select employee;

you do not have to retest the same conditions like you do in

C#

foreach ( Employee emp in objDB_ArjunEntities.Employees.ToList ( ) )
    {
    if ( includeInActive &&
         ( emp.Name.Contains ( searchKey ) ||
           emp.Address.Contains ( searchKey ) ||
           emp.Email.Contains ( searchKey ) ) )
        {
        lstEmployee.Add(emp);
        }
    else if ( !includeInActive &&
              emp.IsActive == true &&
              ( emp.Name.Contains ( searchKey ) ||
                emp.Address.Contains ( searchKey ) ) )
        {
        lstEmployee.Add(emp);
        }
    }

Again, all that you need is

C#

if ( includeInActive )
    {
    lstEmployee.Add ( emp );
    }
else if ( emp.IsActive )
    {
    lstEmployee.Add ( emp );
    }

Note that you are not testing against your sorted list (tmpList) but rather against the contents of objDB_ArjunEntities.Employees.ToList ( ). Was that intended?