Inserting value in two table but it adding same value in 2 rows of second table

Question

1.00/5 (2 votes)

See more:

cmd.CommandText = "INSERT INTO AD_DETAIL (CAT_ID, SUB_CAT_ID, AD_TITLE, AD_DESC, AD_PRICE, AD_IMG, BUY_SELL_ID,DATE,AD_POST_DATE,DELETED_AD) VALUES (" + ddlCountry.SelectedValue + "," + ddlState.SelectedValue + ",'" + txtTitle.Text + "','" + txtDesc.Text + "','" + txtPrice.Text + "','" + "Images/" + uniquefilename + extension + "','" + rbPost.SelectedValue + "', @date,@postdate,0)";

cmd.Parameters.AddWithValue("@date", date.Date.ToLongDateString());
cmd.Parameters.AddWithValue("@postdate", datepost.Date.ToLongDateString());
cmd.Parameters.AddWithValue("@ImagePath", "Images/" + uniquefilename);
cmd.ExecuteNonQuery();

cmd.CommandText = "INSERT INTO SELLER_DETAIL (SELLER_NAME, SELLER_EMAIL_ID, SELLER_MOB_NO, SELLER_DEP, SELLER_FLOOR,EMP_ID) VALUES ('" + txtName.Text + "','" + txtEmailID.Text + "'," + txtContact.Text + ",'" + txtDep.Text + "','" + txtFloor.Text + "','" + txtEmpNo.Text + "')";

Posted 22-Apr-14 12:17pm

Harshit Wadhera

Updated 22-Apr-14 13:18pm

v3

Add a Solution

Comments

[no name] 22-Apr-14 18:55pm

First format your code so that it is readable.
Second, use parameterized queries. Do not mix parameterized queries and sql injection attack queries. It defeats the purpose.
Third, you are executing the query twice.

Harshit Wadhera 22-Apr-14 19:13pm

sir i have update the code.. when i insert values in second table (SELLER_DETAILS)it adds the same data twice.

[no name] 22-Apr-14 19:21pm

Yes. Your code is still unformatted. You are still mixing parameterized queries with SQL Injection attack queries. And even though you removed it, I would bet that you are still executing the query twice.

Harshit Wadhera 22-Apr-14 19:29pm

yes i am executing the query twice because there are two tables in which i have to insert the data.

[no name] 22-Apr-14 19:36pm

No.... you are executing the queries 3 times (according to your first code example). Once for the AD_DETAIL table and TWICE for the SELLER_DETAIL table.

[no name] 22-Apr-14 19:37pm

cmd.CommandText = "INSERT INTO SELLER_DETAIL (SELLER_NAME, SELLER_EMAIL_ID, SELLER_MOB_NO, ¬

SELLER_DEP, SELLER_FLOOR,EMP_ID) VALUES ('" + txtName.Text + "','" + txtEmailID.Text + "'," + ¬

txtContact.Text + ",'" + txtDep.Text + "','" + txtFloor.Text + "','" + txtEmpNo.Text + "')"; ¬

cmd.ExecuteNonQuery();
int i = cmd.ExecuteNonQuery();

Harshit Wadhera 22-Apr-14 19:47pm

Sir may you tell me how i am executing the query of SELLER_DETAILS twice

[no name] 22-Apr-14 19:52pm

You are kidding me right? You seriously cannot see
cmd.ExecuteNonQuery();
int i = cmd.ExecuteNonQuery();
? What is it that you think it's doing?

Harshit Wadhera 22-Apr-14 20:01pm

thank you sir. Its pleasure to talk to you.
I will not forget your help.....
Sir i am beginner in C# now i able to see what i am doing wrong..

[no name] 22-Apr-14 20:39pm

You're welcome. Sorry about the previous. It might have sounded a bit harsh. It really helps to learn to use the debugger. Good luck.

ZurdoDev 22-Apr-14 22:03pm

Looks like this is the solution. please post it.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

sankarsan parida · Answer 1 · 2014-04-22T16:01:00

Why are you trying insert data two table with two times from front end.

Easily you can write a 
1.Storeprocedure with required parameters
2.Writed both of Insert query inside the storeprocedure
3.Call only storeprocedure one time with single connection 
4.It will insert to both of your table.

Tari_ · Answer 2 · 2014-04-22T13:01:00

Solution 1

try creating new instance of cmd after executing the first query ... something like

cmd = new SqlCommand() ;

Posted 22-Apr-14 13:01pm

Tari_

Comments

Harshit Wadhera 22-Apr-14 19:10pm

i have tried this but still not working.

Aravindba · Answer 3 · 2014-04-22T16:55:00

Hi Try like this in first query u use cmd.CommandText and second query also cmd.CommandText so try to declare different cmd(like cmd,cmd1)or if u execute first query u need to dispose the cmd ,i think cmd as sqlcommand ? is it if u use same object u need to dispose like cmd.Dispose() then again u assign the query to cmd.And one this in each function or each query u need to use dispose,close connection then only it not affect in other place,what u try above in same function u try to execute 2 queries with same sqlcommand object,so u have dispose or declare new name cmd.

C#

cmd.CommandText = "INSERT INTO AD_DETAIL (CAT_ID, SUB_CAT_ID, AD_TITLE, AD_DESC, AD_PRICE, AD_IMG, BUY_SELL_ID,DATE,AD_POST_DATE,DELETED_AD) VALUES (" + ddlCountry.SelectedValue + "," + ddlState.SelectedValue + ",'" + txtTitle.Text + "','" + txtDesc.Text + "','" + txtPrice.Text + "','" + "Images/" + uniquefilename + extension + "','" + rbPost.SelectedValue + "', @date,@postdate,0)";
 
cmd.Parameters.AddWithValue("@date", date.Date.ToLongDateString());
cmd.Parameters.AddWithValue("@postdate", datepost.Date.ToLongDateString());
cmd.Parameters.AddWithValue("@ImagePath", "Images/" + uniquefilename);
cmd.ExecuteNonQuery();
 

//Here u use cmd.Dispose(); or declare new cmd1 and use in second query.

cmd.CommandText = "INSERT INTO SELLER_DETAIL (SELLER_NAME, SELLER_EMAIL_ID, SELLER_MOB_NO, SELLER_DEP, SELLER_FLOOR,EMP_ID) VALUES ('" + txtName.Text + "','" + txtEmailID.Text + "'," + txtContact.Text + ",'" + txtDep.Text + "','" + txtFloor.Text + "','" + txtEmpNo.Text + "')";

Regards
Aravind

Inserting value in two table but it adding same value in 2 rows of second table

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0