Please Help. Incorrect Syntax Near '(Whatever Data I Insert)'

Question

2.50/5 (2 votes)

See more:

namespace Company
{
    public partial class Form2 : Form
    {
        SqlConnection con = new SqlConnection(@"Data Source=.\SQLEXPRESS;AttachDbFilename=C:\Users\User\Documents\Company.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True");
        SqlCommand cmd;
        SqlDataAdapter da;
        DataSet ds;
        public Form2()
        {
            InitializeComponent();
        }
        private void button1_Click(object sender, EventArgs e)
        {
            con.Open();
            cmd = new SqlCommand("insert into Login(Username,Password,Phone_No) values('"+textBox1.Text+"','"+textBox2.Text+"','"+textBox3 .Text+"'",con);
            cmd. ExecuteNonQuery();
            con.Close();
            MessageBox.Show("User successfully added");
            this.Hide();
            Form1 form1 = new Form1();
            form1.Show();
        }
    }
}

Posted 24-Apr-14 11:51am

Member 10773287

Updated 24-Apr-14 12:01pm

Richard C Bishop

v2

Add a Solution

Comments

bunzitop 25-Apr-14 2:53am

you are misssing closing bracket in VAULES Clause, near con.

It must be like this

cmd = new SqlCommand("insert into Login(Username,Password,Phone_No) values('"+textBox1.Text+"','"+textBox2.Text+"','"+textBox3 .Text+"' )",con);

Richard C Bishop 25-Apr-14 13:05pm

This is not a good suggestion as you are propagating the dangerous practice of string concatenation in queries. This leaves your application open to SQL injection.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard C Bishop · Answer 1 · 2014-04-24T12:05:00

You should be using parameterized queries to handle this. What you currently have leaves you susceptible to SQL injection.

You want to do something like this:

cmd = new SqlCommand("INSERT INTO Login(Username,Password,Phone_No) VALUES (@UserName,@Password,@Phone_No)",con);
cmd.Parameters.AddWithValue("@UserName",textBox1.Text);
cmd.Parameters.AddWithValue("@Password",textBox2.Text);
cmd.Parameters.AddWithValue("@Phone_No",textBox3.Text);
            cmd. ExecuteNonQuery();