Segmentation fault in C, confused whats going wrong

Question

0.00/5 (No votes)

See more:

While submitted the code its ending up segmentation error , of saying stack overflow

What I have tried:

#include<stdio.h>
int main()
{
    int twen=0,nine=0,other=0,n;
    char cd[1000];
    scanf("%d",n);
    while(n--)
    {
    gets(cd);
    
    if(cd[0] == 'G')
    {
        for(int i=0;cd[i]!='\0';i++)
        {
            if((cd[i]=='1') && (cd[i+1] == '9'))
            {
                nine+=2;
            }
            else if((cd[i]=='2') && (cd[i+1] == '0'))
            {
                twen+=2;
            }
            else if((cd[i]>2) && (cd[i+1]<9))
            {
                other+=2;
            }
        }
    }
      if(cd[0] == 'M')
    {
        for(int i=0;cd[i]!='\0';i++)
        {
            if((cd[i]=='1') && (cd[i+1] == '9'))
            {
                nine+=1;
            }
            else if((cd[i]=='2') && (cd[i+1] == '0'))
            {
                twen+=1;
            }
            else if((cd[i]>'2') && (cd[i+1]<'9'))
            {
                other+=1;
            }
        }
    }
    }
    if(nine>twen)
    printf("Date\n");
    else if(other > twen || other > nine)
    printf("No Date\n");
    else
    printf("No Date\n");
    return 0;
}

Posted 28-Apr-18 19:20pm

Member 13803277

Updated 28-Apr-18 19:49pm

OriginalGriff

v2

Add a Solution

Comments

Patrice T 29-Apr-18 4:22am

What is supposed to be the input.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-04-28T19:50:00

We can't tell you - we don't have access to your data, so we can't try your code under exactly the same conditions you can - and this is almost certainly going to be data related.
But this in your first for loop:

else if((cd[i]>2) && (cd[i+1]<9))

Should probably look like this in your second:

else if((cd[i]>'2') && (cd[i+1]<'9'))

That won't fix your problem though!

Probably though, you are running off the end of your array cd.

So, it's going to be up to you.
Fortunately, you have a tool available to you which will help you find out what is going on: the debugger. How you use it depends on your compiler system, but a quick Google for the name of your IDE and "debugger" should give you the info you need.

Put a breakpoint on the first line in the function, and run your code through the debugger. Then look at your code, and at your data and work out what should happen manually. Then single step each line checking that what you expected to happen is exactly what did. When it isn't, that's when you have a problem, and you can back-track (or run it again and look more closely) to find out why.

Sorry, but we can't do that for you - time for you to learn a new (and very, very useful) skill: debugging!