Simple code mistake ?

Question

1.00/5 (1 vote)

See more:

Doesn't work when I click submit.

                $(document).ready(function(){
                $("#submit-button").click(function(e){

		        var firstName = $("#first-name").val();
                var name_regex = /^[a-zA-Z]+$/;
        if(firstName.length == 0){
			$("#p1").text("*Field must be filled!*");
			$("#first-name").focus();
		}

		else if(!firstName.match(name_regex) || firstName.length == 0 ){
			$("#p1").text("Please use alphabets only.");
			$("#first-name").focus();
		}
	});
});
<input id="submit-button" type="submit" name="submit" value="Submit">

What I have tried:

I've tried to use /-----/i regex instead of /------/. 
I've tried to use alert instead of $("p").text();
I've checked my script src link.

Posted 17-May-18 4:18am

Member 13504137

Updated 17-May-18 5:11am

Clifford Nelson

v3

Add a Solution

Comments

Richard MacCutchan 17-May-18 10:53am

What does "doesn't work" mean?

Member 13504137 17-May-18 10:59am

If I input number in name field I expect a message to pop under input field when I click on Submit button. I expect that because it doesn't fit the regex I've wrote.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2018-05-17T05:12:00

Your code is working, but the page is being submitted before the message can be shown.

You need to call e.preventDefault() if your validation fails:

JavaScript

$(function(){
    $("#submit-button").click(function(e){
        var firstName = $("#first-name").val();
        if (firstName.length === 0){
            $("#p1").text("*Field must be filled!*");
            $("#first-name").focus();
            e.preventDefault();
            return;
        }

        if (!firstName.match(/^[a-zA-Z]+$/)){
            $("#p1").text("Please use alphabets only.");
            $("#first-name").focus();
            e.preventDefault();
            return;
        }
    });
});

You might be better off looking at the jQuery Validation Plugin[^] instead.