problem in inserting recorod

Question

0.00/5 (No votes)

See more:

SQL

cmd = New SqlCommand("insert into Login1 values" & "(" & "'" & TextBox1.Text & "'" & "," & "'" & TextBox2.Text & "'" & "," & "'" & TextBox3.Text & "'" & "," & TextBox4.Text & "," & TextBox5.Text & "," & "'" & TextBox6.Text & "'" & "," & "'" & TextBox7.Text & "'" & ")", cn)

        cmd.ExecuteNonQuery()
        


       adp.Fill(ds, "Login1")
        MsgBox("Record Inserted....")
        ds.Clear()

while I fire this query then record has been inserted twice in my sql database. I can't recognize this bug.
so please help me in this basic stuff.

Posted 27-Sep-11 4:02am

somil030

Updated 27-Sep-11 4:43am

RaviRanjanKr

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RaviRanjanKr · Answer 1 · 2011-09-27T04:34:00

try to write only for save values

cmd = New SqlCommand("insert into Login1 values" & "(" & "'" & TextBox1.Text & "'" & "," & "'" & TextBox2.Text & "'" & "," & "'" & TextBox3.Text & "'" & "," & TextBox4.Text & "," & TextBox5.Text & "," & "'" & TextBox6.Text & "'" & "," & "'" & TextBox7.Text & "'" & ")", cn)
cmd.ExecuteNonQuery()

its not a good practice to save values as you are doing,always try to write Parameterized Insert Command.
take a look Database Parameterized Insert Tutorial[^]