How to make the index within the bounds of array in c#

Question

0.00/5 (No votes)

See more:

Hi,

I have created a form in C#,where I supposed to read data from the text file and make some calculations and display the result on the text box.I got an error stating that the index was outside the bounds of the array.Can anyone suggest me how to resolve this issue

Regards

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;
using System.IO;

namespace VOLTAGESAG
{
    public partial class Form1 : Form
    {
        string s;
        double[] t = new double[1000];
        double[] x = new double[1000];
        double a=0,a1,a2;
        int i = 0,j,p;
        public Form1()
        {
            InitializeComponent();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            StreamReader sw = new StreamReader("C:\\Users\\Sony\\Desktop\\logfiles\\transm10.txt");
            do
            {
                s = sw.ReadLine();
                p = i;
                t[i] = Convert.ToDouble(s);//error occurs here
                i++;

            } while (sw.ReadLine() != null);
            sw.Close();

            for (j = 0; j < i; i++)
            {
                x[j] = t[j] * t[j];
                a = a + x[j];
            }
            a1 = a / i;
            this.Invoke(new EventHandler(DisplayText));
            
        }
        public void DisplayText(object sender, EventArgs e)
        {
            textBox1.Text = a1 + "\n";
        }
    }
}

Posted 25-Apr-14 8:08am

Member 10415564

Add a Solution

Comments

[no name] 25-Apr-14 14:18pm

Finding out what the value of i is at the time of the error should tell you everything you need to know to correct the condition.

Member 10415564 25-Apr-14 14:33pm

Could you please suggest me how to find it or any sample code,since i am a beginner in c#

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-04-25T08:43:00

First problem which springs to mind: if you press the button twice, it will keep going, adding lines.
Second problem: How many rows in your log file? You only allow for 1000 in your arrays, so if it exceeds that...

But please, look at what you are doing! What do you need the array for? All you do with it is read a line, convert it to a double, and store it. Later, you square the value, store that in another array, and then use that array to sum the values. You do not refer to the arrays ever again!

So why use them? And why invoke? It's a button click event, so it's on the correct thread already!
Why not:

C#

private void button1_Click(object sender, EventArgs e)
    {
    StreamReader sw = new StreamReader("C:\\Users\\Sony\\Desktop\\logfiles\\transm10.txt");
    double sum = 0.0;
    do
        {
        double value = Convert.ToDouble(sw.ReadLine());
        sum += value * value;
        } while (sw.ReadLine() != null);
    sw.Close();

    textBox1.Text = sum.ToString();
    }