Syntax error in UPDATE statement. (MS Access)

Question

1.00/5 (1 vote)

See more:

C#

public void Update()
        {
            OleDbConnection conn = new OleDbConnection("Provider=Microsoft.Jet.OLEDB.4.0;Data Source=D:\\Employees.mdb");
            conn.Open();
            OleDbCommand cmd = new OleDbCommand("UPDATE [employee] SET ([Name],[Jobtitle],[Company])Values ('" + Name + "','" + Jobtitle + "','" + Company + "') where [EmpID] = '" + EmpID + "'", conn);
            //OleDbCommand cmd = new OleDbCommand(" update Employee set Name = '" + Name + "',Jobtitle = '" + Jobtitle + "',Company = '" + Company + "'  where EmpID = '" + EmpID + "'", conn);
            cmd.ExecuteNonQuery();
            conn.Close();

        }

Posted 19-Mar-15 9:09am

MeftahDAKHEEL

Updated 20-Mar-15 1:11am

RajeeshMenoth

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-03-19T09:19:00

First off, don't do it like that. Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

The chances are that doing that will fix your problem, but you should also not use "Name" as the name of a column or table - it's an ACCESS keyword, and that may also cause problems. "FullName" or similar is a lot more descriptive as well.

Richard Deeming · Accepted Answer · 2015-03-19T10:04:00

As Griff said, you need to fix the SQL Injection[^] vulnerability in your code.

You also need to fix the syntax of your command - what you currently have does not match the syntax of the UPDATE statement[^].

You should also wrap the connection and command objects in using blocks, to ensure that they get cleaned up properly in every case.

C#

public void Update()
{
    using (OleDbConnection conn = new OleDbConnection("Provider=Microsoft.Jet.OLEDB.4.0;Data Source=D:\\Employees.mdb"))
    using (OleDbCommand cmd = new OleDbCommand("UPDATE [employee] SET [Name] = ?, [Jobtitle] = ?, [Company] = ? WHERE [EmpID] = ?", conn))
    {
        // The OleDbCommand doesn't use named parameters;
        // only the order matters here:

        cmd.Parameters.AddWithValue("p0", Name);
        cmd.Parameters.AddWithValue("p1", Jobtitle);
        cmd.Parameters.AddWithValue("p2", Company);
        cmd.Parameters.AddWithValue("p3", EmpID);

        conn.Open();
        cmd.ExecuteNonQuery();
    }
}

MeftahDAKHEEL · Accepted Answer · 2015-03-19T23:41:00

Solution 3

I want to tell you that i am new programmer...
Thanks a lot to everybody who spent from his/her time to give me a solution, it is working now i hope to finish my first database program.

Posted 19-Mar-15 23:41pm

MeftahDAKHEEL

Syntax error in UPDATE statement. (MS Access)

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0