how to insert into database ?

Question

0.00/5 (No votes)

See more:

i am using this code to insert into database :

C#

SqlConnection conn = new SqlConnection("Server=XP-PC\\SQLEXPRESS;Database=Warehouse;Trusted_Connection=True");
            string sql = "insert into warehouse_data (Barcode,Product_Name,Amount) values ('" + textBox1.Text + "','" + textBox2.Text + "','" + textBox5.Text + "')";
            SqlCommand cmd = new SqlCommand(sql,conn);
            
            try
            {
                conn.Open();
                cmd.ExecuteScalar();
            }
            catch (SqlException ex)
            {
                MessageBox.Show(ex.ToString());
            }
            conn.Close();

but nothing happens
why ?
and this is the right code or not ?

Posted 18-Apr-11 0:27am

Mohammed Ahmed Gouda

Updated 18-Apr-11 0:30am

Tarun.K.S

v2

Add a Solution

Comments

Oshtri Deka 18-Apr-11 6:49am

Which is the type of Amount column? Integer or some kind of char type?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tarun.K.S · Accepted Answer · 2011-04-18T00:33:00

Use ExecuteNonQuery instead of ExecuteScalar.

I would recommend you to read this article : http://blogs.x2line.com/al/archive/2007/05/01/3049.aspx[^]

UPDATE 1:

You can give more proper spacing :

C#

string sql = "INSERT INTO WAREHOUSE_DATA(BarCode, Product_Name, Amount) VALUES('" + textBox1.Text + "','" + textBox2.Text + "','" + textBox5.Text + "')";

Some notes :
- Make sure that the textboxes are not empty.
- Use SqlParameters instead directly assigning textbox.text in the query.
- Any Exception?
- How about checking the data types of the columns?

UPDATE 2:

Comment from OP :
text box are not empty , no exception appears , data types are (nvarchar(50),nvarchar(50)and int)

I think there is a problem in your data type. You are assigning the field of type int to String.
Now change your query to this:

C#

string sql = "INSERT INTO WAREHOUSE_DATA(BarCode, Product_Name, Amount) VALUES('" + textBox1.Text + "','" + textBox2.Text + "', int.Parse(textBox5.Text))";

;

Now it should work. And do use ExecuteNonQuery as ExecuteScalar will return only one record.

Pratik Bhesaniya · Accepted Answer · 2011-04-18T00:48:00

As Tarun says ,
Use ExecuteNonQuery instead of ExecuteScalar.

i can see only this error on your code and yes plz take care of notes written by tarun.

try this ,

SqlCommand comm = new SqlCommand("INSERT INTO desg VALUES (@txtBox1, @txtBox2, @txtBox3)", connection);

comm.Parameters.AddWithValue("@txtBox1", textBox1.Text.Trim());
comm.Parameters.AddWithValue("@txtBox2", textBox2.Text.Trim());
comm.Parameters.AddWithValue("@txtBox3", textBox3.Text.Trim());

C#

try
            {
                conn.Open();
                comm.ExecuteNonQuery ();
            }
            catch (SqlException ex)
            {
                MessageBox.Show(ex.ToString());
            }
            conn.Close();

Refer this link it will definitely help you, [^]

how to insert into database ?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0