Hello, im new to coding and I am not sure what im doing wrong.

Question

0.00/5 (No votes)

See more:

I am unable to make this webpage to display anything. When I try to open it there are no pictures that display. This code is straight from the book other, than the pictures I used.

<title>HTML and JavaScript

var imgArray = new Array(6);
var index = 0;

function cycle()
	{
	  document.banner.src - imgArray[index].src;
	  index++;
	  if (index > 6)
	  {
	    index = 0;
	  }
	  setTimeout("cycle()", 2000);
	  return;
	}
function startup()
	{
	  imgArray[0] = new Image;
	  imgArray[0].src = "Linx.png";
	  imgArray[1] = new Image;
	  imgArray[1].src = "Fish.png";
	  imgArray[2] = new Image;
	  imgArray[2].src = "Crocodile.png";
	  imgArray[3] = new Image;
	  imgArray[3].src = "Gorilla.png";
	  imgArray[4] = new Image;
	  imgArray[4].src = "Giraffe.png";
	  imgArray[5] = new Image;
	  imgArray[5].src = "Elephant.png";
	  imgArray[6] = new Image;
	  imgArray[6].src = "Tiger.png";
	  cycle();
	  return;
	}




 <div align="center">
  
 </div>

What I have tried:

I also saved the pictures as jpeg and that made no difference. I do not have the option to save the pictures as gif.

Posted 1-Oct-20 5:17am

Member 14953455

Updated 1-Oct-20 8:30am

Dave Kreskowiak

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-10-01T05:32:00

Solution 1

At a guess, it can't find the pictures.
Check where you put them - they need to be in the same folder as the page .HTML file.

Posted 1-Oct-20 5:32am

OriginalGriff

Comments

Member 14953455 1-Oct-20 11:38am

That's what I thought I did wrong at first, but I went back and resaved the pictures with the pictures from my old projects. Everything is in my web design folder and it gave me the same results.

Sandeep Mewara · Accepted Answer · 2020-10-01T06:54:00

Solution 2

Well, could it be this typo:

JavaScript

document.banner.src - imgArray[index].src;

Change this to equal to sign from a minus. As long as the images are in the same location as html file, it should pick up the value. Format should not matter.

JavaScript

document.banner.src = imgArray[index].src;

Posted 1-Oct-20 6:54am

Sandeep Mewara

Comments

Member 14953455 1-Oct-20 14:16pm

That's what it was. I didn't notice that typo when I went back through my code. Thank you I appreciate the help!

Sandeep Mewara 1-Oct-20 14:47pm

Welcome!