Incorrect number of parameters for sprintf_s

Question

0.00/5 (No votes)

See more:

We use Veracode for static analysis, and it reported following issue in our code:

This function expects a certain number of parameters based on the syntax of the format string, but the wrong amount are specified to the eventual variable length parameter functions call.

Ensure that the number of parameters matches the number of placeholders in the format string.

Below is the offending line:

C++

CString cs;
char arr[1024];
sprintf_s(arr, sizeof(arr), "<html>\r\n"
        "<head>\r\n"
        "<title>REPORT %s</title>\r\n"
        "</head>\r\n"
        "<body bgcolor=#ffffff>\r\n"
        "<table border=1 cellspacing=0>\r\n"
        "<tr><th bgcolor=#a0ffff colspan=41>REPORT %s</th></tr>\r\n",
        (LPCSTR)cs, (LPCSTR)cs);

I do not see what is the erroneous part of the format string, can you please help?

What I have tried:

I have checked official MSDN documentation for sprintf_s, it referred me to this format specifier page.

After double checking format string against the above page, I found no problem.

I have tried below as well, but got the same error again:

C++

char format_string[] = "<html>\r\n"
        "<head>\r\n"
        "<title>REPORT %s</title>\r\n"
        "</head>\r\n"
        "<body bgcolor=#ffffff>\r\n"
        "<table border=1 cellspacing=0>\r\n"
        "<tr><th bgcolor=#a0ffff colspan=41>REPORT %s</th></tr>\r\n"
CString cs;
char arr[1024];
sprintf_s(arr, sizeof(arr), format_string,
        (LPCSTR)cs, (LPCSTR)cs);

Posted 30-Dec-20 7:53am

MyOldAccount

Updated 30-Dec-20 9:39am

Add a Solution

Comments

CPallini 31-Dec-20 1:58am

I confirm what already said by Rick. Your code is correct and Veracode is wrong.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick York · Accepted Answer · 2020-12-30T09:39:00

The issue here is Veracode is falsely reporting an error. Your format string specifies two arguments and you supplied two arguments so it is incorrect.

I hope you see that your arguments will be an empty string since cs was never set to anything. As an experiment, try this :

C++

PCTSTR arg = "report name";
const int bufferSize = 1023;
char buffer[ bufferSize+1 ] = { 0 };
sprintf_s( buffer, bufferSize, format_string, arg, arg );

Sometimes tools can get confused by casts so this approach has no casts.