problem in sql query

Question

0.00/5 (No votes)

See more:

below i write my sql query

C#

"Insert into tblpayfee(regno,sname,lastname,course,sem,date,fee_amt,paid_amt,remain_amt,fine,tot_amt,amt_words)values('" + txtregno.Text + "','" + txtname.Text + "','" + txtlastname.Text + "','" + txtcourse.Text + "','" + DropDownList2.SelectedItem.ToString() + "','" + txtfeedate.Text + "','" + txtfeeamount.Text + "','" + txtpaidamt.Text + "','" + txtremainamt.Text + "','" + txtfineamt.Text + "','" + txttotamt.Text + "'," + txtamt_words + ")";

but i face problem in execution of this query

The name "System.Web.UI.WebControls.TextBox" is not permitted in this context. Valid expressions are constants, constant expressions, and (in some contexts) variables. Column names are not permitted.<br />

how can solve this problem pls help me

- Suraj

Posted 14-May-13 4:44am

suraj Repe

Updated 14-May-13 4:46am

Maciej Los

v2

Add a Solution

Comments

[no name] 14-May-13 10:53am

You really should be using parameterized queries instead of string concatenation to prevent SQL injection attacks.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RaisKazi · Answer 1 · 2013-05-14T05:03:00

As mentioned in Solution-1 use txtamt_words.Text.

You are using inline query and passing your Input/TextBox values into it. This is a potential risk of SQL Injection.

Have a look at below links to uderstand SQL Injection.
http://en.wikipedia.org/wiki/SQL_injection

http://blogs.technet.com/b/neilcar/archive/2008/05/21/sql-injection-mitigation-using-parameterized-queries.aspx

Solution:- Instead use parameterized query. Have a look at below link.
http://msdn.microsoft.com/en-us/library/system.data.sqlclient.sqlcommand.parameters

Yuriy Loginov · Answer 2 · 2013-05-14T04:47:00

Solution 1

you forgot to use the text property on txtamt_words, use this instead "txtamt_words.Text"

Posted 14-May-13 4:47am

Yuriy Loginov

Updated 14-May-13 4:48am

v2

Comments

Maciej Los 14-May-13 10:52am

That could be it!
+4, because answer is not complete ;(

Yuriy Loginov 14-May-13 11:13am

thanks!