Return Two Values without Tuple or Out?

Question

1.00/5 (1 vote)

See more:

I asked a question a little while ago, so I apologies for asking too many questions too quick. However I am refactoring an application of mine and have been stuck for a while with this.

I have a method that retrives several plants names from a source and I want to return a value of the PlantCount of this list without calling the method to count the list because this would cause it to double.

C#

int PlantCount;

private readonly List<string> _ListOfPlantNames = new List<string>();
public List<string> ListOfPlantNames() 
{
            foreach (HtmlNode insidenode in htmlDocument.DocumentNode.SelectNodes("//h2"))
            {
                if (insidenode.InnerText.Contains("("))
                {
                    int index = insidenode.InnerText.IndexOf("(", System.StringComparison.Ordinal);

                    _ListOfPlantNames.Add(insidenode.InnerText.Substring(0, index));
                }
                else
                {
                    _ListOfPlantNames.Add(insidenode.InnerText);
                }

return _ListOfPlantNames;

} 
}

Code format went wrong, sorry. The only way I can do this is by using a method without returning a property but I would prefer to do it this way if possible.

PlantCount = _ListOfPlantsNames.Count;

I appreciate any help and your time given as always!

Thank you.

Posted 12-Aug-13 2:13am

SteveBaldwin21

Updated 12-Aug-13 2:14am

v2

Add a Solution

2 solutions

Solution 1

C#

PlantCount = _ListOfPlantsNames.Count;

try this

Posted 12-Aug-13 2:20am

Member 9762654

Comments

SteveBaldwin21 12-Aug-13 8:25am

I did and it passed a value of 0.

Maarten Kools 12-Aug-13 8:29am

Did you call your method, ListOfPlantNames()? Is the xpath selector correct?

SteveBaldwin21 12-Aug-13 8:31am

Yep, its called when the list's are assigned to one. Yes the xpath is correct as the values are all correct. It's just I need the count to iterate how many plants to add to the ListView without causing duplication.

Maarten Kools 12-Aug-13 8:34am

Then _ListOfPlantsNames.Count can never be 0.

SteveBaldwin21 12-Aug-13 8:36am

sorry - I mean null rather than 0. No items appear in the listbox meaning that the loop is not iterating because the count is null.

Sorry again.

Maarten Kools 12-Aug-13 8:48am

I have honestly no idea what you mean. What is null? .Count does not return null, it returns an integer. And if something else is null, you'll get a NullReferenceException. And what listbox are you talking about?

SteveBaldwin21 12-Aug-13 8:54am

<pre lang="cs">for (int i = 0; i < PlantCount; i++)
{

_PlantCollection.Add(new PlantCollection()
{
Name = _ListOfPlantNames[i],
URLOfPlant = ListOfURLs()[i],
PlantThumbnail = new BitmapImage(new Uri(ListOfImageSources()[i])),
SafeToFeed = ListOfSafeText()[i],
PlantTrafficColour = ListOfTrafficColours()[i]
});
}</pre>

<pre>PlantListView.ItemsSource = _PlantCollection;</pre>

^^ My listview that displays the plants in the UI.

If the PlantCount is null/0/empty - no items are shown in the Listview. If no Listview items are shown this is an indication that the PlantCount has 0 as a value in the loop, because if I add a value instead of the PlantCount it works as intended.

Hope this makes sense?
Thank you.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

David_Wimbley · Accepted Answer · 2013-08-12T02:30:00

You've got a few issues in that code.

1) You are doing a return inside your foreach loop

C#

foreach (HtmlNode insidenode in htmlDocument.DocumentNode.SelectNodes("//h2"))
            {
                if (insidenode.InnerText.Contains("("))
                {
                    int index = insidenode.InnerText.IndexOf("(", System.StringComparison.Ordinal);

                    _ListOfPlantNames.Add(insidenode.InnerText.Substring(0, index));
                }
                else
                {
                    _ListOfPlantNames.Add(insidenode.InnerText);
                }

return _ListOfPlantNames;
}

This would explain you getting a value of 0. Move that outside your foreach loop and...at least looking at the code you should be good to go.

However if that is not the case, then i would imagine this could be an alternative

C#

public class Plants
{
    public int PlantCount {get;set;}
    
    public Plants()
    {
        ListOfPlantNames();
    }

    public void ListOfPlantNames()
    {
        List<string> _ListOfPlantNames = new List<string>();
        foreach (HtmlNode insidenode in htmlDocument.DocumentNode.SelectNodes("//h2"))
        {
            if (insidenode.InnerText.Contains("("))
            {
                int index = insidenode.InnerText.IndexOf("(", System.StringComparison.Ordinal);

                _ListOfPlantNames.Add(insidenode.InnerText.Substring(0, index));
            }
            else
            {
                _ListOfPlantNames.Add(insidenode.InnerText);
            }
        }

        PlantCount = _ListOfPlantNames.Count;
    }
}

Usage

C#

Plants plant = new Plants();
plant.ListOfPlantNames();
Console.WriteLine(plant.PlantCount);

[Edit]Moved method call into constructor[/Edit]

If this still does not work then i would start to think that the issue lies somewhere in your foreach loop/conditions of the loop/conditions within the loop. But you should be able to just do list.Count either ways...just my code above provides you an alternative (a good one? who knows...but it should work). Also, if this doesn't work, could you post some of your HTML for me to look at/run my code against. That would help so i could see what is going on as i don't have access to your PC.