Why this foreach dont work?

Question

0.00/5 (No votes)

See more:

im triying use foreach in a dataset to update a sql server, if the element alredy exist just catch the error and try with the next. My table have 13 elements and this foreach is giving the error of the first element 13 times :

System.Data.SqlClient.SqlException (0x80131904): Violation of PRIMARY KEY constraint ;PK_share1;. Cannot insert duplicate key in object ;dbo.share1&. The duplicate key value is (4008).

if (changes != null)
                    {
                        foreach (DataTable table in changes.Tables)
                        {
                            foreach (DataRow dr in table.Rows)
                            {
                                try
                                {
                                    adapter.Update(changes);
                                    
                                }

                                catch (Exception ex)
                                {
                                    Console.WriteLine(ex.ToString());
                                   
                                }

                              
                            }
                        }
                    }

Posted 25-May-15 0:47am

Member 11716735

Updated 25-May-15 1:03am

Frankie-C

v2

Add a Solution

2 solutions

Solution 1

You are not really do an in-loop update here, but rather call Update on your DataAdapter for each row in each table...
The problem is that DataAdapter.Update - internally - runs over all the rows that have a status of inserted, updated or deleted...
Please read here: https://msdn.microsoft.com/en-us/library/system.data.common.dataadapter.update(v=vs.110).aspx?cs-save-lang=1&cs-lang=csharp#code-snippet-1[^]

Posted 25-May-15 1:02am

Kornfeld Eliyahu Peter

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 11716735 · Accepted Answer · 2015-05-25T04:55:00

Solution 3

my solution for do exactly what i want:

SQL

adapter.ContinueUpdateOnError = true;
                  adapter.Update(changes);

Posted 25-May-15 4:55am

Member 11716735