Re: nested classes - C# Discussion Boards

11-Sep-13 1:51

I am new to C#. I have in mind a nested class structure. First of all. Is this optimal? Secondly, please could someone provide the coded outline of this structure so that I can work on filling and coding the functions.

class Z

// performs calculation

class Y

// retrieves result from calculation and prints to file


class X

// runs through coordinate possibilities
// calls calculation one coordinate combination at a time


class V

// takes input file from command line
// calls input file and processes to produce array
// requests calculation using hashed array of array

Member 1026649411-Sep-13 2:00

11-Sep-13 2:00

I'm really short of time on this task.

The task is to take a csv file.
Process a list of x,y specified coordinate points.
Work out the distance between all these coordinate points.
Print results to file

Ta

Keith Barrow11-Sep-13 2:17

Keith Barrow

11-Sep-13 2:17

Is this for an interview or something?

PB 369,783 wrote:
I just find him very unlikeable, and I think the way he looks like a prettier version of his Mum is very disturbing.[^]

Member 1026649411-Sep-13 3:13

11-Sep-13 3:13

yes. got it in one. 10 years since i coded in C# and I underestimated the task.

Dave Kreskowiak11-Sep-13 4:54

Dave Kreskowiak

11-Sep-13 4:54

Well, time management is part of the interview process for projects like this. Do you really need me to tell you how you've done on that part?

Nobody is going to do your work for you.

A guide to posting questions on CodeProject[^]

Dave Kreskowiak

NotPolitcallyCorrect11-Sep-13 2:41

NotPolitcallyCorrect

11-Sep-13 2:41

Member 10266494 wrote:
short of time on this task

So you left doing your homework assignment until the last minute and expect us to do it for you?

V.11-Sep-13 3:20

11-Sep-13 3:20

I would avoid nested classes whenever I can, but that's just my personal opinion.

V.

(MQOTD Rules and previous Solutions )

How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

Richard MacCutchan11-Sep-13 6:19

Richard MacCutchan

11-Sep-13 6:19

This is the third time you have asked what is basically the same question. Nested classes is not the answer, as you obviously don't understand what they are. Take Pete O'Hanlon's advice and go and work through Charles Petzold's free book. You cannot learn how to write good code by repeating the same question in a forum like this.

Veni, vidi, abiit domum

babak1411-Sep-13 1:33

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

11-Sep-13 1:33

I don't know where I made mistake.I checked everything !! but this error happened :
"Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

thank you in advance.

int i = 1;
int RowNo = 0;
int CellNo = 0;


foreach (DataGridViewRow row in Firstdgv.Rows)
{

    foreach (DataGridViewCell cell in row.Cells)
    {
        if (i > Finaldgv.Columns.Count)
            break;
        Finaldgv.Rows[RowNo].Cells[CellNo].Value = cell.Value;
        i++;
        CellNo++;

    }
    RowNo++;
    i = 1;
    CellNo = 0;
}

OriginalGriff11-Sep-13 2:31

OriginalGriff

11-Sep-13 2:31

At a guess - and that's about it it can be from that little code - you haven't allocated any rows or columns in the destination DGV, or you are trying to access different sized DGVs.
So when you try to access it's Rows collection via an index:

Finaldgv.Rows[RowNo]

Or the resulting DataGridViewRow Cells collection:

Finaldgv.Rows[RowNo].Cells[CellNo]

It complains becasue it doesn't exist.

Start this way: put a breakpoint on the if line, and single step through from there - look at the variables as you go, and look for null values. (It may help to "break out" the line assigning the row so that each part to the left of a "." is a separate variable - you don't need to, but it makes it easier to see without complex use of the debugger)

DataGridViewRow row = Finaldgv.Rows[RowNo];
DateGridViewCell cell = row.Cells[CellNo];

And so forth.

PS: Keep an eye on the value of i...

This message is manufactured from fully recyclable noughts and ones. To recycle this message, please separate into two tidy piles, and take them to your nearest local recycling centre.
Please note that in some areas noughts are always replaced with zeros by law, and many facilities cannot recycle zeroes - in this case, please bury them in your back garden and water frequently.

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

Keith Barrow11-Sep-13 2:40

Keith Barrow

11-Sep-13 2:40

First, the value of i isn't doing anything according to your code, you should be able to remove it and use CellNo instead. Personally I'd move the declaration of CellNo inside the first foreach loop, that way you can also remove the line CellNo = 0; at the end.

int RowNo = 0;

foreach (DataGridViewRow row in Firstdgv.Rows)
{
    int CellNo = 0;
    foreach (DataGridViewCell cell in row.Cells)
    {
        if (CellNo >= Finaldgv.Columns.Count)
            break;
        Finaldgv.Rows[RowNo].Cells[CellNo].Value = cell.Value;
        CellNo++;                  
    }
    RowNo++;
}

If this doesn't fix your problem (I doubt it will) you need to figure out which of the two indexes is wrong - you can put a breakpoint on, or you could temporarily amend Finaldgv.Rows[RowNo].Cells[CellNo].Value = cell.Value; to:

var tempRow = Finaldgv.Rows[RowNo]
var tempCell = tempRow.Cells[CellNo]
tempCell.Value = cell.Value

And see which line breaks - my initial gut reaction is you have no rows.

PB 369,783 wrote:
I just find him very unlikeable, and I think the way he looks like a prettier version of his Mum is very disturbing.[^]

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

babak1411-Sep-13 5:27

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

11-Sep-13 5:27

my dear friend ,at first I am so appriciate for your attention.
I revised the code as you said but the error still exist !! Frown | :(

the error happens in the "***" line
when the RowNo=1 error occurs !!

// int i = 1;
                   int RowNo = 0;
                   //int CellNo = 0;


                   foreach (DataGridViewRow row in Firstdgv.Rows)
                   {
                       int CellNo = 0;
                       foreach (DataGridViewCell cell in row.Cells)
                       {
                           if (CellNo >= Finaldgv.Columns.Count)
                               break;
                           var tempRow = Finaldgv.Rows[RowNo]; ***
                           var tempCell = tempRow.Cells[CellNo];
                           tempCell.Value = cell.Value;
                           //Finaldgv.Rows[RowNo].Cells[CellNo].Value = cell.Value;
                           //i++;
                           CellNo++;

                       }
                       RowNo++;
                       //i = 1;
                       //CellNo = 0;
                   }

Pete O'Hanlon11-Sep-13 5:38

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

11-Sep-13 5:38

When you put a break point on var tempRow..., and inspect the value, what do you find? The thing that stands out to me here is that you have an assumption that Finaldgv has more than one row, and there's no guarantee that this is the case.

Chill _Maxxx_

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

babak1411-Sep-13 5:53

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

11-Sep-13 5:53

I want to copy Firstdgv rows to Finaldgv rows.So how can I refer to the second,third and... rows in Finaldgv in order to copy the second ,third and .... Firstdgv rows .
I think your assumption is right.but what should I do?

Pete O'Hanlon11-Sep-13 6:31

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

11-Sep-13 6:31

If you are trying to copy the values from one grid into another (and I'm assuming the second one is empty), then you Add the rows into the other grid.

Chill _Maxxx_

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

babak1411-Sep-13 7:25

Re: How can I solve thiss error : "Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index"

11-Sep-13 7:25

thank you my friend Smile | :)

it works

thank you ALL Wink | ;)

Pete O'Hanlon11-Sep-13 7:55

11-Sep-13 7:55

You're welcome. I'm glad I could be of service.

Chill _Maxxx_

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

reading table from csv

Member 1026649411-Sep-13 0:17

Re: reading table from csv

11-Sep-13 0:17

<pre lang="css">using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;


namespace ConsoleApplication1
{
    public class Building
    {

           // csv File contains :


            //Id    X   Y
            //0 91  57
            //1 67  24
            //2 27  27
            //3 97  56
            //4 25  19
            //5 95  18
            //6 5   69
            //7 46  94
            //8 29  68
            //9 92  28


            int[] list1  = new int[3] { 0, 91, 57 };
            int[] list2  = new int[3] { 1, 67, 24 };
            int[] list3  = new int[3] { 2, 27, 27 };
            int[] list4  = new int[3] { 3, 97, 56 };
            int[] list5  = new int[3] { 4, 25, 19 };
            int[] list6  = new int[3] { 5, 95, 18 };
            int[] list7  = new int[3] { 6, 5, 69 };
            int[] list8  = new int[3] { 7, 46, 94 };
            int[] list9  = new int[3] { 8, 29, 68 };
            int[] list10 = new int[3] { 9, 92, 28 };

            //int[][][] lists = new int[][][] { list1, list2, list3, list4, list5, list6, list7, list8, list9, list10 };



           for (int i = 0; i < 4; i++)
            {

                int numberIn = list1[i];
                System.Console.WriteLine(numberIn);

            }


    }
}

I wish to modify this class to allow me to read a csv file in and present an array of arrays that can be returned to a 'stem' class. What is the simplist code that will achieve this please?

Pete O'Hanlon11-Sep-13 3:37

Re: reading table from csv

11-Sep-13 3:37

Seriously, you could solve this part with a simple Google search. You really need to learn how to do that part. I'll give you a couple of hints here:

Your data is in a File. You want to Read All Lines from that file.
Once the data is in lines of strings, you want to Split each string into it's constituent parts.

It's that simple.

Chill _Maxxx_

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

Bernhard Hiller11-Sep-13 3:37

Bernhard Hiller

11-Sep-13 3:37

csv stands for comma separated values. The lines below your comment do not show any comma between the values, rather spaces. If all of your values are simple numbers and separated by spaces, just read the file line by line and get the contents with string[] contents = line.Split(' ');, then parse each item of contents into an int (int.Parse(...) or int.TryParse(...)).

working out a triangle hypotenuse

Member 1026649410-Sep-13 23:56