SQL Update record from textfields

Question

1.00/5 (1 vote)

See more:

How should I modify this code to Update my record in the database?

C#

private void KlantenInfoUploaden()
        {
            string Organisatie = TX_Organisatie.Text;
            string BezoekAdres = TX_BezoekAdres.Text;
            String BezoekPostCode = TX_BezoekPostCode.Text;
            string BezoekPlaats = TX_BezoekPlaats.Text;

            string FactuurAdres = TX_FactuurAdres.Text;
            string FactuurPostCode = TX_FactuurPostCode.Text;
            string FactuurPlaats = TX_FactuurPlaats.Text;

            string Telefoon = TX_Telefoon.Text;
            string Fax = TX_Fax.Text;
            string Email = TX_Email.Text;
            string Website = TX_Website.Text;

            const string queryKLantBewerkenID = "Update Organisatie, bezoek_adres, bezoek_postcode, bezoek_plaats, factuur_adres, factuur_postcode, factuur_plaats, telefoon, fax, mail, website FROM Klanten WHERE [IDklanten] = @KlantID";

            using (SqlConnection connection = new SqlConnection(connectionstring))
            using (SqlCommand command = new SqlCommand(queryKLantBewerkenID, connection))
            { 
                command.Parameters.AddWithValue("@KlantID", XX_klantID.Text);

                try {
                    connection.Open();
                    
              //HELP!


                }
                catch(Exception exp) {
                    MessageBox.Show("FOUT");
                }
                
            }
        }

Posted 15-Dec-15 4:47am

MaikelO1

Updated 15-Dec-15 20:44pm

phil.o

v2

Add a Solution

2 solutions

Solution 1

C#

command.ExecuteNonQuery();

seems a reasonable choice.

Posted 15-Dec-15 4:59am

phil.o

Comments

MaikelO1 15-Dec-15 11:01am

Where do I add this?

phil.o 15-Dec-15 11:09am

Inside the try..catch block seems a good idea.
But you should have a look at solution 2 before, which hold a good advise about your update query itself.

OriginalGriff 15-Dec-15 11:07am

Have you looked at the SQL command?

phil.o 15-Dec-15 11:13am

No, I must confess I just gave the query a miss and went directly to the //HELP comment. Thanks for pointing it out :)

OriginalGriff 15-Dec-15 11:25am

You're welcome! :laugh:

MaikelO1 16-Dec-15 2:38am

It works! thanks!

What is your advice to write out all parameters. it should be so? Or can i write multiple parameters in a string?;
command.Parameters.AddWithValue("@KlantID", XX_klantID.Text);
command.Parameters.AddWithValue("@ORG", TX_Organisatie.Text);

phil.o 16-Dec-15 2:47am

I don't really understand your question :)
There you will find an example of SQL parameter usage; I'm not aware of another way to do it, and I would certainly not advise to group several parameters into a single string.

MaikelO1 16-Dec-15 4:00am

Tnxs!

phil.o 16-Dec-15 4:02am

You're welcome.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-12-15T05:06:00

Your SQL command is not valid: If I rip out most of it so it;s more readable then it comes down to:

SQL

Update Organisatie FROM Klanten WHERE [IDklanten] = @KlantID

Which is the format for a SELECT command not an update.
You need:

SQL

UPDATE Klanten SET Organisatie=@ORG WHERE [IDklanten] = @KlantID

And to supply the "@ORG" value via a parameter in the same way you do @KlantID.
Then a command.ExecuteNonQuery will do the update.