not all code paths return a value can any one please provide a solution

Question

1.00/5 (1 vote)

See more:

C#

public class ProductModel
{
   public string InsertProduct(Product product)
   {
      try
      {
         GarageEntities db = new GarageEntities();
         db.Products.Add(product);
         db.SaveChanges();

         return product.Name + "was succesfully inserted";
      }
      catch (Exception e)
      {
         return "Error:" + e;
      }
   }

Posted 15-Dec-15 22:00pm

Member 12210733

Updated 15-Dec-15 22:08pm

phil.o

v2

Add a Solution

Comments

Andy Lanng 16-Dec-15 4:09am

I just tried your code and it's fine. Maybe VS has bugged out. Try restarting VS

Leo Chapiro 16-Dec-15 4:21am

Marked as "Unclear/Incomplete"

Jochen Arndt 16-Dec-15 4:50am

"not all code paths return a value" is a compiler warning message.
So badly formulated but not unclear.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2015-12-15T22:48:00

The compiler complains about a missing return statement at the end of the function (he is not smart enough to detect that the end is never reached). You have three options:

Ignore or suppress the warning (nonprofessional).
Return the result at the end (move the return from the try block to the end).
Return something at the end.

For the third case with comments for the second case:

C#

public string InsertProduct(Product product)
{
   try
   {
      GarageEntities db = new GarageEntities();
      db.Products.Add(product);
      db.SaveChanges();
      // May be moved to end of function
      return product.Name + "was succesfully inserted";
   }
   catch (Exception e)
   {
      return "Error:" + e;
   }
   // Make the compiler happy or return success here
   return "";
}

[EDIT]
A tip for asking about such problems:
Always include the compiler code (CS0161 here) because this makes it clear what happened. However, searching the web for the message and/or code would have answered this too.