Why doesn't this code work?

Question

0.00/5 (No votes)

See more:

C#

Public Class Form1
    Function Data()
        Dim speed As Single
        Dim distance, time, average_speed As Integer

        txttime1.Text = CInt(time)
        txttime2.Text = CInt(time)
        txttime3.Text = CInt(time)
        txttime4.Text = CInt(time)

        speed = distance / time

        Dim valid_chars As String
        valid_chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"

        Dim valid_int As Integer = "1234567890"

        average_speed = 31.3

        Dim foreign As String
        foreign = Rnd(valid_chars & valid_int & valid_chars & valid_int)

        Dim uk_plate As String
        uk_plate = Rnd(valid_chars & valid_chars & valid_int & valid_int & valid_chars & valid_chars & valid_chars)

This is my code, I need help with a solution.
My aim is to create a car plate and I need help creating a car plate w/ the UK car plate format (2 letters, 2 numbers and 3 letters in that order)

Posted 4-Jan-16 23:56pm

Member 12244927

Updated 5-Jan-16 0:07am

Leo Chapiro

v2

Add a Solution

Comments

John C Rayan 5-Jan-16 6:03am

More details would help.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Leo Chapiro · Answer 1 · 2016-01-05T00:05:00

Solution 1

Take a look at this code:

VB

' You have declared a variable time, the value in VB is initialized with 0
Dim distance, time, average_speed As Integer

' ...

' ... you try to divide through null
speed = distance / time

Posted 5-Jan-16 0:05am

Leo Chapiro

OriginalGriff · Answer 2 · 2016-01-05T00:06:00

It doesn't work because it doesn't do anything.
All it does is add the string "ABCDEFGHIJKLMNOPQRSTUVWXYZ" to itself 5 times, include the interes twice and pass that:

"ABCDEFGHIJKLMNOPQRSTUVWXYZ12345678901234567890ABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJKLMNOPQRSTUVWXYZ"

to the Rnd fucntion. Which almost certainly doesn't know what to do with it...

Throw that away.
Move your valid_chars and valid_int to class level Shared strings.
Create a class level Random instance, and GetLetter and GetDigit methods which use it to generate an index into the appropriate Shared string and return a single character.
Then call them the appropriate number of times.

But...be aware that that won't necessarily generate a valid UK number plate: AA99AAA will not be valid for a lot of years, and AA16III or AA16OOO will never be valid...

Why doesn't this code work?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us