Login help C# login saying incorrect when info is

Question

0.00/5 (No votes)

See more:

Please help me with this code when they login right it still says username and password is wrong pl0x help.

C#

private void button3_Click(object sender, EventArgs e) 
{ 
  if (textBox1.Text == "Quinn") 
  { 
    if (textBox2.Text == "Qmanqtip12") 
    { 
      System.Threading.Thread.Sleep(4000); 
      MessageBox.Show("Welcome To AL7", "Login Succesfull", 
      MessageBoxButtons.OK, MessageBoxIcon.Information); 
      new Form2().Show(); 
      this.Hide(); 
    } 
    else 
    { 
      MessageBox.Show("Usename or Password Incorrect", "Error", 
      MessageBoxButtons.OK, MessageBoxIcon.Exclamation); 
    } 
  } 

  MessageBox.Show("Usename or Password Incorrect", "Error", 
  MessageBoxButtons.OK, MessageBoxIcon.Error); 
}

What I have tried:

I have tried taking away thread sleeping but it no help

Posted 17-Dec-16 7:26am

Member 12896541

Updated 17-Dec-16 8:13am

Kornfeld Eliyahu Peter

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Perić Željko · Accepted Answer · 2016-12-17T07:52:00

I think that above code should be changed :

private void button3_Click(object sender, EventArgs e) 
{ 
  if (textBox1.Text == "Quinn" && textBox2.Text == "Qmanqtip12") 
  {   
      System.Threading.Thread.Sleep(4000); 
      MessageBox.Show("Welcome To AL7", "Login Succesfull", 
      MessageBoxButtons.OK, MessageBoxIcon.Information); 
      new Form2().Show(); 
      this.Hide(); 
    
  else 
  { 
      MessageBox.Show("Usename or Password Incorrect", "Error", 
      MessageBoxButtons.OK, MessageBoxIcon.Exclamation); 
  } 
}

Kornfeld Eliyahu Peter · Accepted Answer · 2016-12-17T08:13:00

If you carefully check your flow, you will see that the second 'incorrect username or password' message box is outside any conditional branch (if)! That's the reason it always shows.
So adding the correct else will fix it, however you should not have that messages twice, but instead as about username and password in a single if, like this:

C#

if ((textBox1.Text == "Quinn") && (textBox2.Text == "Qmanqtip12"))
{ 
  System.Threading.Thread.Sleep(4000); 
  MessageBox.Show("Welcome To AL7", "Login Succesfull", 
  MessageBoxButtons.OK, MessageBoxIcon.Information); 
  new Form2().Show(); 
  this.Hide(); 
} 
else 
{ 
  MessageBox.Show("Usename or Password Incorrect", "Error", 
  MessageBoxButtons.OK, MessageBoxIcon.Exclamation); 
}

Login help C# login saying incorrect when info is

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0