Login using XML data

Question

0.00/5 (No votes)

See more:

I trying to check login credential from XML file

What I have tried:

I tried following code,
Any suggestions as i used .where
it shows it cannpot converted to bool.

C#

<pre>protected void Submit_Click(object sender, EventArgs e)
        {
            string Username = txtUsername.Text;
            string Password = EncDec.Encrypt(txtPassword.Text);
            string FilePath = Server.MapPath("~/Logs/Login.xml");
            XDocument Loginxml = new XDocument();
            var LoginCheck = Loginxml.Descendants("userDetails")
                .Where(x => (string)x.Attribute("Username") == Username && (string)x.Attribute("Password") == Password );
            if (LoginCheck)
            {
                DisplayMessage.Visible = true;
                DisplayMessage.Text = "Login Successful";
                Response.Redirect("AdminMaster.aspx");
            }
            else
            {
                DisplayMessage.Visible = true;
                DisplayMessage.Text = "Invalid Username/Password";
            }
        }

XML Content:-

XML

<userDetails Username="TestAdmin"  EmailID="shridhar.salunkhe@grassdew.com" Password="YhY3rY4RCt9XVUiNfaOKmCMP7HADqexWdFHfXc4k3hQ=" />

Posted 7-Mar-17 17:21pm

Shridhar Salunkhe

Updated 7-Mar-17 23:55pm

Add a Solution

Comments

Richard Deeming 9-Mar-17 12:47pm

That looks like a security breach waiting to happen!

Unless you take specific steps to secure it, anyone can download the Logs/Login.xml file and read all of the credentials for your site.

You're storing the passwords in plain-text, so they don't even need to expend any effort to use the credentials - just copy and paste, and you're logged in.

Also, since you're not using any access control, there's nothing to stop a user navigating directly to AdminMaster.aspx without having to log in.

Don't try to re-invent the wheel. Use one of the built-in security systems instead - for example, ASP.NET Identity[^].

2 solutions

Solution 1

The code look a little bit odd

1. The XML document wasn't loaded

This line

C#

XDocument Loginxml = XDocument.Load();

Should be

C#

XDocument Loginxml = XDocument.Load(FilePath);

2. The LoginCheck is a type IEnumerable, not a boolean, maybe the code should check if the query return any result, I'm assuming each username and password is unique

C#

if (LoginCheck.Count() == 1)
            {

            }
            else
            {

            }

Posted 7-Mar-17 19:02pm

Bryian Tan

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

M,AqibShehzad · Accepted Answer · 2017-03-07T23:55:00

Here is the 100% full working code of your problem

string Username = "TestAdmin";
       string Password = "YhY3rY4RCt9XVUiNfaOKmCMP7HADqexWdFHfXc4k3hQ=";
       string FilePath = Server.MapPath("~/Login.xml");
       XDocument Loginxml = XDocument.Load(FilePath);
       var LoginCheck = Loginxml.Descendants("userDetails")
                .Where(x => (string)x.Attribute("Username") == Username &&      (string)x.Attribute("Password") == Password);
       if (LoginCheck.Any())
       {

           Response.Redirect("AdminMaster.aspx");
       }
       else
       {
           Response.Redirect("Login.aspx");
       }

Step 1: you missed to load the file

XDocument Loginxml = XDocument.Load(FilePath);

Step 2: it shows it cannot converted to bool because it return enumerable type but you are declared it to use like bool, better is to use the way i have pasted suggested solution.