Moving Files

Question

0.00/5 (No votes)

See more:

I need to move files from one folder to another. Can anyone tell me what is wrong with this code.

DirectoryInfo dir1 = new DirectoryInfo(@"C:\Users\Test\Testing.txt");
DirectoryInfo dir2 = new DirectoryInfo(@"C:\Users\Test2");

FileInfo[] Folder1Files = dir1.GetFiles();
if (Folder1Files.Length > 0)
{
   foreach (FileInfo aFile in Folder1Files)
   {
     if (File.Exists(dir2 + aFile.Name))
     {
         File.Delete(dir2 + aFile.Name);
     }
     aFile.MoveTo(dir2 + aFile.Name);
   }
}

When I run this code nothing happens. Any help will be appreciated.

Posted 14-Oct-10 3:14am

Neil Cross

Updated 14-Oct-10 3:23am

Marc A. Brown

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

N_tro_P · Accepted Answer · 2010-10-14T03:15:00

Your dir1 is not actually a directory... I mean it could be but it really looks like a text file.

I am guessing you want to do this:

DirectoryInfo dir1 = new DirectoryInfo(@"C:\Users\Test");
DirectoryInfo dir2 = new DirectoryInfo(@"C:\Users\Test2");
FileInfo[] Folder1Files = dir1.GetFiles();
if (Folder1Files.Length > 0)
{
    foreach (FileInfo aFile in Folder1Files)
    {
       if (File.Exists(dir2.Name + aFile.Name))
       {
           File.Delete(dir2.Name + aFile.Name);
       }
       aFile.MoveTo(dir2.Name + aFile.Name);
    }
}

Note: I also added ".Name" to your directory info objects. This pulls the directory name rather than a direct ToString. Not sure what the direct ToString gets you but .Name is what you should use.