Left shifting the characters of a string by x bits specified by the user

Question

1.00/5 (1 vote)

See more:

I am trying to left shift characters of a string by x bits specified by the user. The shifting operation is not working as desired.

What I have tried:

#include <iostream>
#include <stdio.h>
using namespace std;

void display(char *name, int l)
{
	int i;
	for(i=0;i<=l;i++)
		cout<<name[i];
}
void shiftop(char *name, int shiftbit, int l) //l=stringlength
{
 int sb,i=1;
 char temp;
 
 for(sb=shiftbit+1;sb<=l;sb++)
 {
 	temp=name[i];
 	name[i]=name[sb];
 	name[sb]=temp;
 	i++;

 }
 display(name,l);
}
int main(){

int l,s;
char name[30];
cout<<"Enter the string";
gets(name);
cout<<"shift bit ";
cin>>s;
l=sizeof(name);
shiftop(name,s,l);

}

Posted 14-Jul-17 2:03am

hchaithanya

Updated 14-Jul-17 10:57am

Add a Solution

Comments

CPallini 14-Jul-17 8:54am

What is exactly your requirement? Please provide an example of input and expected output.

Dave Kreskowiak 14-Jul-17 17:23pm

"Not working as desired" is not a proper problem description. What is the input, what is the expected output, and what did you get?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-07-14T02:29:00

That's because your code has nothing at all to do with bits: it swaps characters about, is all. Bit shifting is the process of moving data within a byte, and possibly between bytes.
So if you start with the value 42 - Hex 2A, Binary 00101010 - and left shift it 2 bits, you get binary 10101000 - hex A8, decimal 168 - and two zero bits to insert at the bottom of the previous byte when you shift that.

What that code does is just swap whole characters about and is nothing like what you need.
Look at the << and the & binary operators, but you will need unsigned chars to do this properly.

Patrice T · Answer 2 · 2017-07-14T10:57:00

Quote:
The shifting operation is not working as desired.

This is not informative ! We have no idea about what is desired. The code you show is not related to bit shifting.
Only you Know what is desired, use the debugger to see what your code is doing, it may help you to see what is wrong.

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

Left shifting the characters of a string by x bits specified by the user

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0