How do I resolve this error?

Question

1.00/5 (1 vote)

See more:

Am getting the error that says "

Notice: Undefined index: text1

"

<div class="formRow">
                            <div class="grid2"><label><?php echo $lang['Timezone']; ?>:</label></div>
                            <div class="grid10">
                               <?php
				$query_timezone1=mysql_query("SELECT * FROM tbl_timezone WHERE id!='$db_timezone_id' ORDER BY timezone ASC");
				$option_timezone1="";
				while($row=mysql_fetch_array($query_timezone1)) {
				$option_timezone1 .= "<option value='$row[id]'";
				$option_timezone1 .= ">". $row['text1'] ." ". $row['timezone'] ."</option>";  }
				?>    
				<select name="timezone" id="timezone"  data-placeholder="Choose" class="select" tabindex="2" style="width:100%;">
                                <?php if($db_timezone_id!=0){echo "<option value='$db_timezone_id'>$db_timezone_code1 $db_timezone_timezone</option>"; }else{echo"<option value=''></option> ";}?>
				<?php echo $option_timezone1; ?>
				</select>
                            </div>             
                    </div>

What I have tried:

i have tried to identify the source of the error but all in vain

Posted 1-Oct-17 22:43pm

Member 10578733

Updated 1-Oct-17 23:11pm

Add a Solution

3 solutions

Solution 3

First of all, remove the *, add column name instead, for better practice:
example:

SQL

-- the no no
SELECT * FROM tbl_;

-- suggested
SELECT COL_1, COL_2,...,COL_3 FROM tbl_;

mysql_fetch_array()[^] returns both 0 base indexing and column name indexing. On the other hand mysql_fetch_assoc()[^]

I prefer mysql_fetch_assoc, (one less indexing)

For understanding why your are not getting why you are missing column,
use

PHP

print_r($row);

further suggestion, Stop using mysql_* functions, try mysqli_*; better yet use mysqli class[^]

try using mysqli::prepare[^]. SQL injection is a real problem.

Take a look at SQL injection

Posted 1-Oct-17 23:10pm

Mohibur Rashid

Comments

Member 10578733 2-Oct-17 5:28am

Thanks for the advise and i will make changes to my code

Solution 2

PHP

$query_timezone1=mysql_query("SELECT * FROM tbl_timezone WHERE id!='$db_timezone_id' ORDER BY timezone ASC");

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
PHP: SQL Injection - Manual[^]

SQL Injection[^]
SQL Injection Attacks by Example[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]

Posted 1-Oct-17 23:05pm

Patrice T

Comments

Member 10578733 2-Oct-17 5:14am

thanks for the advise on sql injection and will try to resolve it

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mehdi Gholam · Accepted Answer · 2017-10-01T22:49:00

Solution 1

Your data returned from the select statement does not have a 'text1' column -> $row['text1']

Run your query and see what actual column names you have.

Posted 1-Oct-17 22:49pm

Mehdi Gholam

Comments

Member 10578733 2-Oct-17 5:01am

thanks for the response,do i have to create a row in my database?

Mehdi Gholam 2-Oct-17 5:03am

If you need the 'text1' column then yes, create the column.