Disposed object

Question

0.00/5 (No votes)

See more:

Suppose I have two forms(Form1,Form2)
in form 1 I have a button

C#

namespace sample_form
{
    public partial class Form1 : Form
    {
        Form2 f = new Form2();
        public Form1()
        {
            InitializeComponent();
        }
        private void button1_Click(object sender, EventArgs e)
        {
            f.Show();
        }
    }
}

in form 2 I have a textbox;

I want to show/close form2 in button1_click(in form1)
it says object disposed !,for this in form2 I wrote

C#

private void Form2_FormClosing(object sender, FormClosingEventArgs e)
        {
            e.Cancel = true;
            this.Hide();
        }

but if user open the form2 and write somthing in textbox and close it,then open form2 by the button , the text he wrote remains in textbox (because I just hide it),how can I instance a new one from Form2 without the error:disposed ?! :((

Posted 23-Oct-10 19:53pm

Nima.naqipoor

Add a Solution

3 solutions

Solution 2

Why do u hide it? What for?
Just create new instance of your form.

C#

private void button1_Click(object sender, EventArgs e)
{
    f = new Form2();
    f.Show();
}

Also, as I understand, the garbage collector will dispose your form in some time, and f.Show will throw an exception. So, create instance every time.

Posted 24-Oct-10 4:30am

Tony Sherlock

Solution 3

If you absolutely need to reuse the same form instance, then write a Clear method that restores the UI to the default state before re-showing it.

Or if that's not a requirement, instantiate a new form instance each time you want to show it (as neosRu suggested above).

Posted 24-Oct-10 4:58am

Nish Nishant

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Accepted Answer · 2010-10-23T20:53:00

private void Form2_FormClosing(object sender, FormClosingEventArgs e)
        {
            e.Cancel = true;
            this.Hide();
        }

This code appears to be in form2 rather than form 1. This is creating the error. You need to place this code in form1 and set form2 to null from there.